Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving experimental to testkit #876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edmondop
Copy link

@edmondop edmondop commented Apr 3, 2024

Changes

This PR renames experimental to testkit, updates the codegen configuration, and the example that uses GoMock to encourage users to use the generated mocks

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@@ -12,8 +12,8 @@
".codegen/service-pkg.go.tmpl": "service/pkg.go",
".codegen/error_mapping.go.tmpl": "apierr/error_mapping.go",
".codegen/error_alias.go.tmpl": "error_alias.go",
".codegen/mock_workspace_client.go.tmpl": "experimental/mocks/mock_workspace_client.go",
".codegen/mock_account_client.go.tmpl": "experimental/mocks/mock_account_client.go"
".codegen/mock_workspace_client.go.tmpl": "testkit/mocks/mock_workspace_client.go",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not rename this to anything else just yet.


```go
ctrl := gomock.NewController(t)
defer ctrl.Finish()
client := mocks.NewMockWorkspaceClient(t)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please limit the changes only to readme.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do with the example? I think it refers to a service that has been renamed from dbfs to files maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants