Cleanup unnecessary codes by the inheritance of dbt-spark any more. #40
Conversation
| {% endif %} | ||
| {% endmacro %} | ||
|
|
||
|
|
||
| {% materialization snapshot, adapter='databricks' %} |
There was a problem hiding this comment.
It looks like you discovered this yourselves, but just for the sake of stating clearly:
Materializations don't natively support the same sort of "parent" adapter inheritance as other macros. I'm going to open an issue in dbt-core that addresses this. In the meantime, you can "mock" that inheritance (and avoid duplicated code) via:
{% materialization snapshot, adapter='databricks' %}
{# this actually calls the spark version of the snapshot materialization #}
{% set relations = materialization_snapshot_spark() %}
{{ return(relations) }}
{% endmaterialization %}This isn't a capability we document or recommend for end users, but we use it in dbt-snowflake as well. Any better approach we implement in a new dbt-core minor version will aim to include a non-breaking upgrade path / backwards compatibility for this syntax.
There was a problem hiding this comment.
Thanks for letting me know. That's great to know.
Actually for this materialization, there are some updates for dbt-databricks from dbt-spark, so I think we still need to redefine here.
|
Thanks! merging. |
Description
Cleans up codes and macros that are unnecessary after the inheritance of
dbt-sparkany more.