Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add koalas accessor and a method to attach a unique id column #1613

Merged
merged 5 commits into from
Jul 3, 2020
Merged

Add koalas accessor and a method to attach a unique id column #1613

merged 5 commits into from
Jul 3, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jun 26, 2020 •
edited by HyukjinKwon
Loading

Add koalas accessor and a few util methods:

  • DataFrame.koalas.attach_id_column

Resolves #1612

@ueshin ueshin requested a review from HyukjinKwon June 26, 2020 01:44
@itholic
Copy link
Contributor

itholic commented Jun 28, 2020

LGTM except several nit comments.

@candalfigomoro
Copy link

Maybe

  • attach_sequence_column
  • attach_distributed_sequence_column
  • attach_distributed_column

could be renamed to something like

  • attach_sequence_id_column
  • attach_distributed_sequence_id_column
  • attach_distributed_id_column

(notice the additional "id" in names)

to make it clear what it is, otherwise it's not really clear what "attach_distributed_column" does until you read the documentation.

@HyukjinKwon HyukjinKwon changed the title Add utils accessor and a few util methods. Add koalas accessor and several methods to attach a unique id column Jul 3, 2020
@HyukjinKwon HyukjinKwon changed the title Add koalas accessor and several methods to attach a unique id column Add koalas accessor and a method to attach a unique id column Jul 3, 2020
@HyukjinKwon HyukjinKwon merged commit feb75e5 into databricks:master Jul 3, 2020
@ueshin ueshin deleted the utils_accessor branch July 3, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itholic itholic itholic left review comments

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an utility to add an increasing id column
4 participants
@ueshin @itholic @candalfigomoro @HyukjinKwon