Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename spark columns only when index=False. #1649

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Rename spark columns only when index=False. #1649

merged 1 commit into from
Jul 15, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jul 14, 2020

Consolidates the logic for Index.to_frame() and MultiIndex.to_frame() and rename Spark columns only when index=False.
Related to #1647 (comment), but not fully fixes it.

@ueshin ueshin requested a review from HyukjinKwon July 14, 2020 01:15
@ueshin
Copy link
Collaborator Author

ueshin commented Jul 15, 2020

Thanks! I'd merge this now.

@ueshin ueshin merged commit 1e1882b into databricks:master Jul 15, 2020
@ueshin ueshin deleted the to_frame branch July 15, 2020 17:37
@itholic
Copy link
Contributor

itholic commented Jul 16, 2020 •
edited
Loading

+1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ueshin @itholic @HyukjinKwon