-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support callable instances to apply as a function, and fix groupby.apply to keep the index when possible #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
built-in-apply
branch
from
July 30, 2020 05:10
c9c3166
to
6cbe7c9
Compare
…le instances when applying a function
HyukjinKwon
force-pushed
the
built-in-apply
branch
from
July 30, 2020 05:15
6cbe7c9
to
e9db30b
Compare
itholic
reviewed
Jul 30, 2020
itholic
reviewed
Jul 30, 2020
itholic
reviewed
Jul 30, 2020
itholic
reviewed
Jul 30, 2020
itholic
reviewed
Jul 30, 2020
LGTM except several nit suggestions. |
ueshin
reviewed
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, and I agree with @itholic's suggestion.
Otherwise, LGTM.
Merged. Thanks guys for reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things.
Support
Callable
instances that are not functions:Keep index name when
DataFrameGroupBy
returns aSeries
:Resolves #1684