Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type of to_koalas and to_pandas #1857

Merged
merged 5 commits into from
Oct 17, 2020

Conversation

xinrong-meng
Copy link
Contributor

Add return type of to_koalas and to_pandas

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM, pending tests.

databricks/koalas/frame.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #1857 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1857   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files          40       40           
  Lines        9737     9737           
=======================================
  Hits         9167     9167           
  Misses        570      570           
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.76% <100.00%> (ø)
databricks/koalas/series.py 96.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62baecc...c8a49ba. Read the comment docs.

databricks/koalas/frame.py Outdated Show resolved Hide resolved
databricks/koalas/frame.py Outdated Show resolved Hide resolved
@ueshin
Copy link
Collaborator

ueshin commented Oct 17, 2020

Thanks! merging.

@ueshin ueshin merged commit fc19f9b into databricks:master Oct 17, 2020
@xinrong-meng
Copy link
Contributor Author

@ueshin Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants