Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the default plotly backend from matplotlib to plotly #2033

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Switch the default plotly backend from matplotlib to plotly #2033

merged 2 commits into from
Mar 3, 2021

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 2, 2021 •
edited
Loading

This PR proposes to switch the default plotly backend from matplotlib to plotly.

Resolves #1933

@HyukjinKwon
Copy link
Member Author

This is dependent on #2028

@HyukjinKwon HyukjinKwon force-pushed the plotly-default branch 3 times, most recently from 7399609 to a8f6519 Compare February 2, 2021 05:47
@HyukjinKwon HyukjinKwon marked this pull request as draft February 2, 2021 06:02
@HyukjinKwon HyukjinKwon force-pushed the plotly-default branch 5 times, most recently from 9908db5 to 1ba3631 Compare February 2, 2021 08:35
@HyukjinKwon HyukjinKwon marked this pull request as ready for review February 2, 2021 10:26
@HyukjinKwon
Copy link
Member Author

I tested this also on Databricks notebooks.

HyukjinKwon
HyukjinKwon commented Feb 2, 2021
View reviewed changes
dev/gendoc.py
@@ -215,7 +215,7 @@ def download_pandoc_if_needed(path):
if not os.path.isfile(filename) or not os.path.isfile("pandoc"):
def download_pandoc():
try:
return pandoc_download.download_pandoc(targetfolder=path, version="latest")
return pandoc_download.download_pandoc(targetfolder=path, version="1.19.1")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails to download the latest one. I just picked one stable version.

@HyukjinKwon HyukjinKwon force-pushed the plotly-default branch 2 times, most recently from 7b1131a to 914b8d5 Compare February 3, 2021 00:04
@HyukjinKwon
Copy link
Member Author

The 10 mins notebook has too many diff because of the interactive plots. It can be reviewed via here: http://mybinder.org/v2/gh/hyukjinkwon/koalas/plotly-default?filepath=docs%2Fsource%2Fgetting_started%2F10min.ipynb

@HyukjinKwon HyukjinKwon mentioned this pull request Feb 3, 2021
Closed
10 tasks
@codecov-io
Copy link

codecov-io commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #2033 (27a54a5) into master (708796c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
+ Coverage   94.74%   94.76%   +0.01%     
==========================================
  Files          54       55       +1     
  Lines       11675    11700      +25     
==========================================
+ Hits        11062    11087      +25     
  Misses        613      613
Impacted Files Coverage Δ
databricks/conftest.py 100.00% <ø> (ø)
databricks/koalas/config.py 99.00% <ø> (ø)
databricks/koalas/plot/core.py 93.77% <ø> (ø)
...ks/koalas/tests/plot/test_frame_plot_matplotlib.py 100.00% <100.00%> (ø)
...s/koalas/tests/plot/test_series_plot_matplotlib.py 100.00% <100.00%> (ø)
databricks/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708796c...da464a3. Read the comment docs.

ueshin
ueshin reviewed Feb 17, 2021
View reviewed changes
.github/workflows/master.yml Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
databricks/koalas/plot/core.py Show resolved Hide resolved
HyukjinKwon
HyukjinKwon commented Feb 19, 2021
View reviewed changes
requirements-dev.txt
@@ -37,3 +37,6 @@ openpyxl
# https://stackoverflow.com/questions/65254535/xlrd-biffh-xlrderror-excel-xlsx-file-not-supported
# We can remove this upperbound when our minimum pandas version is 0.25+.
xlrd<2.0.0

# PIP only dependency
sphinx-plotly-directive
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harupy, would it be possible to release sphinx-plotly-directive on Conda?

@HyukjinKwon
Copy link
Member Author

I will merge this and go ahead but please post-review and see if there are anything wrong. cc @xinrong-databricks and @ueshin too. I know this is a breaking change but I do think this is a better way to go.

@HyukjinKwon HyukjinKwon merged commit e6f90e8 into databricks:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueshin ueshin ueshin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement plots and switch the default plot backend to plotly
3 participants
@HyukjinKwon @codecov-io @ueshin