[PLAT-106952] fix the bug that the delay should only happen if the sts has pods to be updated #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyi
commented
Apr 28, 2024
| ongoing, err := c.updateStatefulSetPods(ctx, sts) | ||
| if err != nil { | ||
| // Do not continue with other StatefulSets because this StatefulSet | ||
| // is expected to be successfully updated before proceeding. | ||
| c.updateLastUpdatedSts(sts) |
There was a problem hiding this comment.
don't update last sts since it is an error, just let operator reconcile again
|
lgtm, would you also mind testing by manually deleting a pod during update? |
hczhu-db
approved these changes
Apr 29, 2024
…s has pods to be updated Signed-off-by: Yi Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
