Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-111199] Terminate Statefulset only if enough pods are available #5

Merged
merged 6 commits into from
Jul 3, 2024
Merged

[PLAT-111199] Terminate Statefulset only if enough pods are available #5

merged 6 commits into from
Jul 3, 2024

Conversation

yuchen-db
Copy link

this is to support minReadySeconds that solves the race condition during rolling update
thanos-io/thanos#4831 (comment)

jnyi
jnyi approved these changes Jul 1, 2024
View reviewed changes
Copy link

@jnyi jnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

christopherzli
christopherzli approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@christopherzli christopherzli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fix, please also address test failures

@yuchen-db yuchen-db force-pushed the PLAT-111199 branch 11 times, most recently from 130450d to 7d0b62e Compare July 3, 2024 03:53
@yuchen-db yuchen-db merged commit dd54955 into main Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherzli christopherzli christopherzli approved these changes

@jnyi jnyi jnyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuchen-db @christopherzli @jnyi