Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification for enumerations #75

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Clarification for enumerations #75

merged 1 commit into from
Nov 13, 2019

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Nov 11, 2019

In the PR, I propose to clearly describe the convention for enumeration classes/objects and its values. Also I added an example.

@MaxGekk
Copy link
Member Author

MaxGekk commented Nov 11, 2019

/cc @dongjoon-hyun @srowen Who reviewed the PR for Spark: apache/spark#26455

@MaxGekk
Copy link
Member Author

MaxGekk commented Nov 11, 2019

@rxin Please, take a look at the PR.

@dongjoon-hyun
Copy link
Contributor

Thank you for pinging me, @MaxGekk . But, this is Databricks repo. :)

@srowen
Copy link

srowen commented Nov 11, 2019

Yeah, it's public though unless I'm totally missing something and serves as the de facto Spark style guide? anyway you're welcome to comment in any event of course. And make changes, etc

@rxin rxin merged commit 6ad8b79 into databricks:master Nov 13, 2019
@rxin
Copy link
Contributor

rxin commented Nov 13, 2019

Thanks @MaxGekk

HyukjinKwon added a commit to HyukjinKwon/scala-style-guide that referenced this pull request Nov 19, 2019
@HyukjinKwon
Add Korean translation for databricks#75
89d8d18
@HyukjinKwon HyukjinKwon mentioned this pull request Nov 19, 2019
Merged
HyukjinKwon added a commit that referenced this pull request Nov 21, 2019
@HyukjinKwon
Add Korean translation for #75 (#76)
fdccf0e 
This PR adds the translation for #75.
jiangr added a commit to jiangr/scala-style-guide that referenced this pull request Dec 27, 2019
@jiangr
Add Chinese translation for databricks#75
c76869f
@jiangr jiangr mentioned this pull request Dec 27, 2019
Merged
rxin pushed a commit that referenced this pull request Apr 3, 2020
@jiangr
Chinese translation for recent updates (#78)
79b4a5d 
* Add Chinese translation for #68

* Add Chinese translation for #75

* Add Chinese translation for #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxGekk @dongjoon-hyun @srowen @rxin