Update the TPCDS schema based on the Spark codebase #201
+534
−444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
commented
Apr 26, 2021
|
|
||
| val dataGenerator = new DSDGEN(dsdgenDir) | ||
|
|
||
| /** | ||
| * Datatype mapping for TPC-DS and Spark SQL, fully matching schemas defined in `tpcds.sql` of the |
There was a problem hiding this comment.
This comment was copied from TPCDSBase in Spark. cc: @yaooqinn
maropu
commented
Apr 26, 2021
| 'cs_net_paid_inc_ship_tax .decimal(7,2), | ||
| 'cs_net_profit .decimal(7,2)), | ||
| """ | ||
| |`cs_sold_date_sk` INT, |
There was a problem hiding this comment.
Since ColumnName does not have a helper method for char/varchar types, I've replaced schema fields with a string schema.
|
cc: @HyukjinKwon @npoggi |
|
Thanks for the update, I'll take a closer look later during the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to update the TPCDS schema based on the Spark codebase.
I've manually checked that tables can be generated in spark-3.0/3.1/master.