Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-102919] adding unit test as well as fix a few bugs to remove overlapping blocks #17

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[PLAT-102919] adding unit test as well as fix a few bugs to remove overlapping blocks #17

merged 2 commits into from
Mar 14, 2024

Conversation

jnyi
Copy link
Collaborator

@jnyi jnyi commented Mar 13, 2024 •
edited
Loading

`

  • | ts=2024-03-13T21:14:57.805442354Z caller=compact.go:527 level=error name=pantheon-downsampler msg="critical error detected; halting" err="compaction: group 0@11398085741180110399: pre compaction overlap check: overlaps found while gathering blocks. [mint: 1707091200000, maxt: 1707264000000, range: 48h0m0s, blocks: 3]: <ulid: 01HQF8F6FE261PA6AE180907XN, mint: 1706745600000, maxt: 1707436800000, range: 192h0m0s>, <ulid: 01HQFKZM9Q2EW39YJB6AHSQC19, mint: 1706918400000, maxt: 1707955200000, range: 288h0m0s>, <ulid: 01HP79ZH7M35BH6WXS0M0TMHW0, mint: 1707091200000, maxt: 1707264000000, range: 48h0m0s>"
    -- | --
    `
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@jnyi jnyi changed the title [PLAT-102919] stop halting even no vertical compaction [PLAT-102919] adding unit test as well as fix the log entry for labels map Mar 14, 2024
@jnyi jnyi force-pushed the PLAT-102919 branch 7 times, most recently from 6ad543a to cabff23 Compare March 14, 2024 04:41
@jnyi jnyi changed the title [PLAT-102919] adding unit test as well as fix the log entry for labels map [PLAT-102919] adding unit test as well as fix a few bugs to remove overlapping blocks Mar 14, 2024
@jnyi jnyi merged commit 52a035c into databricks:db_main Mar 14, 2024
12 checks passed
@christopherzli
Copy link

should we also publish this to upstream as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hczhu-db hczhu-db hczhu-db approved these changes

@christopherzli christopherzli Awaiting requested review from christopherzli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnyi @christopherzli @hczhu-db