Add counters for migrated and pending migration data objects

databrickslabs · Oct 23, 2024 · 3428059 · 3428059
1 parent cc0753f
commit 3428059
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/src/databricks/labs/ucx/queries/progress/main/02_1_pending_migration_data_objects.sql b/src/databricks/labs/ucx/queries/progress/main/02_1_pending_migration_data_objects.sql
@@ -0,0 +1,4 @@
+/* --title 'Pending migration' --description 'Total number of tables and views' --height 6 */
+SELECT COUNT(*) AS count
+FROM ucx_catalog.multiworkspace.latest_historical_per_workspace
+WHERE object_type = "migration_status" AND SIZE(failures) > 0
diff --git a/...1_migration_status_by_owner_bar_graph.sql → ...2_migration_status_by_owner_bar_graph.sql b/...1_migration_status_by_owner_bar_graph.sql → ...2_migration_status_by_owner_bar_graph.sql
@@ -1,5 +1,7 @@
 /*
---title 'Tables and views not migrated'
+--title 'Pending migration'
+--description 'Tables and views per owner'
+--width 5
 --overrides '{"spec": {
     "version": 3,
     "widgetType": "bar",

diff --git a/src/databricks/labs/ucx/queries/progress/main/02_3_migrated_data_objects.sql b/src/databricks/labs/ucx/queries/progress/main/02_3_migrated_data_objects.sql
@@ -0,0 +1,4 @@
+/* --title 'Migrated' --description 'Total number of tables and views' --height 6 */
+SELECT COUNT(*) AS count
+FROM ucx_catalog.multiworkspace.latest_historical_per_workspace
+WHERE object_type = "migration_status" AND SIZE(failures) == 0
diff --git a/..._2_migration_status_by_owner_overview.sql → ..._4_migration_status_by_owner_overview.sql b/..._2_migration_status_by_owner_overview.sql → ..._4_migration_status_by_owner_overview.sql
@@ -1,4 +1,4 @@
-/* --title 'Tables and views migration completion (%)' --description 'Per owner' */
+/* --title 'Overview' --description 'Tables and views migration' --width 5 */
 WITH migration_statuses AS (
     SELECT *
     FROM ucx_catalog.multiworkspace.latest_historical_per_workspace

diff --git a/tests/integration/queries/test_migration_progress.py b/tests/integration/queries/test_migration_progress.py
@@ -320,11 +320,19 @@ def test_migration_progress_dashboard(
         ("01_6_percentage_pipeline_migration_readiness", [Row(percentage=50.0)]),
         ("01_7_percentage_policy_migration_readiness", [Row(percentage=50.0)]),
         (
-            "02_1_migration_status_by_owner_bar_graph",
+            "02_2_migrated_data_objects",
+            [Row(count=5)],
+        ),
+        (
+            "02_2_pending_migration_data_objects",
+            [Row(count=5)],
+        ),
+        (
+            "02_3_migration_status_by_owner_bar_graph",
             [Row(owner="Andrew", count=1), Row(owner="Cor", count=4)],
         ),
         (
-            "02_2_migration_status_by_owner_overview",
+            "02_4_migration_status_by_owner_overview",
             [
                 Row(owner="Andrew", percentage=50.0, total=2, total_migrated=1, total_not_migrated=1),
                 Row(owner="Cor", percentage=42.857142857142854, total=7, total_migrated=3, total_not_migrated=4),