More ownership classes #2999
Closed
More ownership classes #2999
+88
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Error
ericvergnaud
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 21/21 passed, 4 skipped, 27m13s total Running from acceptance #6835 |
1 task
asnare
approved these changes
Oct 17, 2024
| assert ownership.owner_of(my_cluster_record) == ws.current_user.me().user_name | ||
| assert ownership.owner_of(their_cluster_record) == another_user.user_name | ||
| info_ownership = ClusterInfoOwnership(administrator_locator) | ||
| assert info_ownership.owner_of(my_cluster_record) == ws.current_user.me().user_name |
There was a problem hiding this comment.
ws.current_user.me() is a REST call, so it's probably polite to factor that out as a local variable rather than call it twice.
| admin_locator.get_workspace_administrator.return_value = "an_admin" | ||
|
|
||
| ownership = ClusterDetailsOwnership(admin_locator) | ||
| owner = ownership.owner_of(ClusterDetails(cluster_id="1")) |
There was a problem hiding this comment.
I know the default for creator_name is None, but I think I prefer to explicitly provide it because it's an important detail for what we're testing.
| admin_locator.get_workspace_administrator.return_value = "an_admin" | ||
|
|
||
| ownership = JobOwnership(admin_locator) | ||
| owner = ownership.owner_of(Job(job_id=1)) |
There was a problem hiding this comment.
Likewise here with creator_user_name=None.
nfx
requested changes
Oct 17, 2024
| @@ -192,6 +192,16 @@ def _maybe_direct_owner(self, record: ClusterInfo) -> str | None: | |||
| return record.creator | |||
|
|
|||
|
|
|||
| class ClusterDetailsOwnership(Ownership[ClusterDetails]): | |||
There was a problem hiding this comment.
where is it coming from? we don't have a concept of cluster details in our object model - we just have a cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Existing Ownership classes deal with inventory objects.
We sometimes also need to get ownership from workspace objects.
This PR implements these for
JobandClusterDetailsLinked issues
Progresses #1415
Functionality
None
Tests