Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a dead (ownership-related) class #3004

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove a dead (ownership-related) class #3004

merged 1 commit into from
Oct 17, 2024

Conversation

asnare
Copy link
Contributor

@asnare asnare commented Oct 17, 2024

Changes

This PR trivially removes a dead class; this was detritus left over from an intermediate version of the ownership mechanism that limited Record to dataclass classes. However this limitation was removed prior to the original code being merged (and the mechanism can be used with any class).

This was detritus; an intermediate version of the ownership mechanism bound `Record` to dataclasses, but that restriction was removed along the way.
@asnare asnare added the internal this pull request won't appear in release notes label Oct 17, 2024
@asnare asnare self-assigned this Oct 17, 2024
@asnare asnare requested a review from a team as a code owner October 17, 2024 13:32
Copy link

✅ 5/5 passed, 1m7s total

Running from acceptance #6851

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit fa83145 into main Oct 17, 2024
7 checks passed
@nfx nfx deleted the drop-dead-code branch October 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal this pull request won't appear in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants