Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced a static ownership crawler #3111

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Introduced a static ownership crawler #3111

wants to merge 35 commits into from

Commits on Nov 13, 2024

  1. Added TableOwnership resolution logic

    @nfx @FastLee
    nfx authored and FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c973b05 View commit details
    Browse the repository at this point in the history

  2. Determine ownership of tables in the inventory based on the following… 

    … rules:

- If a table is owned by a principal in the grants table, then that principal is the owner.
- If a table is written to by a query, then the owner of that query is the owner of the table.
- If a table is written to by a notebook or file, then the owner of the path is the owner of the table.
    @nfx @FastLee
    nfx authored and FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0225ca4 View commit details
    Browse the repository at this point in the history

  3. ...

    @nfx @FastLee
    nfx authored and FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    eed6d76 View commit details
    Browse the repository at this point in the history

  4. ...

    @nfx @FastLee
    nfx authored and FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1748b38 View commit details
    Browse the repository at this point in the history

  5. Use table ownership heuristics for migrating ACLs 

    This PR prepends `OWN` grants when migrating ACLs for tables. For detailed logic on ownership heuristics, see #3066
    @nfx @FastLee
    nfx authored and FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1455371 View commit details
    Browse the repository at this point in the history

  6. ...

    @nfx @FastLee
    nfx authored and FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ad8d557 View commit details
    Browse the repository at this point in the history

  7. Added skip ACL and fixed OWNER functionality.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    da0a5da View commit details
    Browse the repository at this point in the history

  8. Added tests

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c93615e View commit details
    Browse the repository at this point in the history

  9. Added missing property

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c422228 View commit details
    Browse the repository at this point in the history

  10. Fixed test coverage.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7e64c92 View commit details
    Browse the repository at this point in the history

  11. Added functionality for a static Ownership for tables.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b2cc246 View commit details
    Browse the repository at this point in the history

  12. Fixed Unit Tests

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bdfff7e View commit details
    Browse the repository at this point in the history

  13. Fixed Unit Tests

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8291bcb View commit details
    Browse the repository at this point in the history

  14. Addressed Integration Tests

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d93767d View commit details
    Browse the repository at this point in the history

  15. Addressed Integration Tests Issues

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a1e65dd View commit details
    Browse the repository at this point in the history

  16. Addressed Integration Tests Issues

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f258faa View commit details
    Browse the repository at this point in the history

  17. Added CLI Option

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ac6978f View commit details
    Browse the repository at this point in the history

  18. Fixed FMT Issues

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bd6f5be View commit details
    Browse the repository at this point in the history

  19. Added unit test for CLI

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    032d6cc View commit details
    Browse the repository at this point in the history

  20. Addressing Review Comment. Removing SKIP ACLS functionality.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5b22313 View commit details
    Browse the repository at this point in the history

  21. Introduced test ownership

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a26653c View commit details
    Browse the repository at this point in the history

  22. Add unit tests

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4d519e8 View commit details
    Browse the repository at this point in the history

  23. Added integration test and converted from username to userid for memb… 

    …ership lookup
    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c3b0bb3 View commit details
    Browse the repository at this point in the history

  24. Added integration test and converted from username to userid for memb… 

    …ership lookup
    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4719349 View commit details
    Browse the repository at this point in the history

  25. Rebased

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b2e93e4 View commit details
    Browse the repository at this point in the history

  26. Added coverage

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bb15b2a View commit details
    Browse the repository at this point in the history

  27. Added command description to README.md

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    603efb0 View commit details
    Browse the repository at this point in the history

  28. Fixed README.md

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fe47b55 View commit details
    Browse the repository at this point in the history

  29. Added test coverage.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a940902 View commit details
    Browse the repository at this point in the history

  30. Added test coverage.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3f1e6e8 View commit details
    Browse the repository at this point in the history

  31. Added test coverage.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e7042ee View commit details
    Browse the repository at this point in the history

  32. Added test coverage.

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9dd1bbf View commit details
    Browse the repository at this point in the history

  33. Addressed review comments

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    86fdcb9 View commit details
    Browse the repository at this point in the history

  34. Added test coverage

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0584327 View commit details
    Browse the repository at this point in the history

  35. Added test coverage

    @FastLee
    FastLee committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ab4bc78 View commit details
    Browse the repository at this point in the history