Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new import convention for scikit-image. #299

Merged
merged 10 commits into from
Sep 5, 2023

Conversation

mkcor
Copy link
Contributor

@mkcor mkcor commented Sep 4, 2023

Dear @datacarpentry/image-processing-curriculum-maintainers,

As per the Aug 30 meeting with @tobyhodges and @datacarpentry/curriculum-advisors-image, this PR:

Best,
Marianne

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-299

The following changes were observed in the rendered markdown documents:

 02-image-basics.md         | 20 +++++-------
 03-skimage-images.md       | 38 +++++++++++------------
 04-drawing.md              | 45 ++++++++++++++-------------
 05-creating-histograms.md  | 20 ++++++------
 06-blurring.md             | 29 +++++++++---------
 07-thresholding.md         | 35 ++++++++++-----------
 08-connected-components.md | 76 ++++++++++++++++++++++------------------------
 09-challenges.md           | 28 ++++++++---------
 md5sum.txt                 | 18 +++++------
 setup.md                   |  5 +--
 10 files changed, 153 insertions(+), 161 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-04 19:19:28 +0000

github-actions bot pushed a commit that referenced this pull request Sep 4, 2023
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mkcor 🙌

@tobyhodges tobyhodges merged commit 0c29d28 into datacarpentry:main Sep 5, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
Auto-generated via {sandpaper}
Source  : 0c29d28
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-09-05 08:21:04 +0000
Message : Merge pull request #299 from mkcor/new-import-ski

Use new import convention for scikit-image.
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
Auto-generated via {sandpaper}
Source  : b80f6b1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-05 08:22:19 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0c29d28
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-09-05 08:21:04 +0000
Message : Merge pull request #299 from mkcor/new-import-ski

Use new import convention for scikit-image.
@mkcor mkcor deleted the new-import-ski branch September 5, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition to new import convention for sckit-image?
2 participants