Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping low intensity pixels #310

Merged
merged 10 commits into from
Dec 13, 2023

Conversation

JeremyPike
Copy link
Contributor

@JeremyPike JeremyPike commented Dec 1, 2023

I've made a few changes to this exercise to either make it easier for participants to follow or to correct some minor mistakes.
Instructions

  1. Tell participants to load as grayscale rather than as a hint.
  2. Hint now to look at cmap, vmin and vmax arguments for matplotlib.pyplot.imshow as these are needed and vmin and vmax havn't been introduced yet.

Solution

  1. There are a few discrepancies/mistakes between the text and the code. Specifically the code dosn't load in grayscale, uses a different threshold value and incorrect vmin and vmax.
  2. When copying the image array I assign to a new variable and display both original and modified images at the end. I think this is nice but not essential.

Copy link

github-actions bot commented Dec 1, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-310

The following changes were observed in the rendered markdown documents:

 03-skimage-images.md | 25 ++++++++++++++++---------
 md5sum.txt           |  2 +-
 2 files changed, 17 insertions(+), 10 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-11 11:16:47 +0000

@JeremyPike JeremyPike marked this pull request as ready for review December 1, 2023 13:53
github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
Copy link
Contributor

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @JeremyPike! I remember there were issues with this exercise and I guess its fixing was never completed... I like your changes and additions.

episodes/03-skimage-images.md Outdated Show resolved Hide resolved
episodes/03-skimage-images.md Outdated Show resolved Hide resolved
episodes/03-skimage-images.md Outdated Show resolved Hide resolved
episodes/03-skimage-images.md Outdated Show resolved Hide resolved
episodes/03-skimage-images.md Outdated Show resolved Hide resolved
JeremyPike and others added 5 commits December 8, 2023 07:59
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
Co-authored-by: Marianne Corvellec <[email protected]>
@JeremyPike
Copy link
Contributor Author

Thank you, @JeremyPike! I remember there were issues with this exercises and I guess its fixing was never completed... I like your changes and additions.

Thank you @mkcor for the review and nice changes!

@JeremyPike JeremyPike requested a review from mkcor December 8, 2023 08:02
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
Copy link
Contributor

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

episodes/03-skimage-images.md Outdated Show resolved Hide resolved
Co-authored-by: Marianne Corvellec <[email protected]>
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
@tobyhodges tobyhodges merged commit b9bc009 into datacarpentry:main Dec 13, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Auto-generated via {sandpaper}
Source  : b9bc009
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-13 09:44:57 +0000
Message : Merge pull request #310 from bear-rsg/keeping-low-intensity-pixels

Keeping low intensity pixels
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Auto-generated via {sandpaper}
Source  : b175e96
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-13 09:45:54 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b9bc009
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-13 09:44:57 +0000
Message : Merge pull request #310 from bear-rsg/keeping-low-intensity-pixels

Keeping low intensity pixels
@JeremyPike JeremyPike deleted the keeping-low-intensity-pixels branch February 2, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants