Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create section about image loading. #311

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

mkcor
Copy link
Contributor

@mkcor mkcor commented Dec 1, 2023

Closes #242.

After discussing with the other @datacarpentry/curriculum-advisors-image, I have reorganized the beginning of episode 02 (Image Basics) to include a "Loading images" section.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Copy link

github-actions bot commented Dec 1, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-311

The following changes were observed in the rendered markdown documents:

 02-image-basics.md | 134 ++++++++++++++++++++++++++++++++++-------------------
 md5sum.txt         |   2 +-
 2 files changed, 88 insertions(+), 48 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-09 16:04:26 +0000

github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
@mkcor
Copy link
Contributor Author

mkcor commented Dec 2, 2023

As mentioned before, with a109ed5, I've included this note by @soupault, adapting it slightly to fit the context of the lesson.

github-actions bot pushed a commit that referenced this pull request Dec 2, 2023
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkcor I like this. Making only one suggestion, to include the output of the call to type

episodes/02-image-basics.md Show resolved Hide resolved
Co-authored-by: Toby Hodges <[email protected]>
@mkcor
Copy link
Contributor Author

mkcor commented Dec 9, 2023

Thanks @mkcor I like this. Making only one suggestion, to include the output of the call to type

Sure, thank you!

github-actions bot pushed a commit that referenced this pull request Dec 9, 2023
Copy link
Contributor

@uschille uschille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this too - thanks @mkcor!

@tobyhodges tobyhodges self-requested a review December 11, 2023 10:00
@tobyhodges tobyhodges merged commit 49112f9 into datacarpentry:main Dec 11, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
Auto-generated via {sandpaper}
Source  : 49112f9
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-11 10:01:03 +0000
Message : Merge pull request #311 from mkcor/add-loading-section

Create section about image loading.
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
Auto-generated via {sandpaper}
Source  : 9cc0929
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-11 10:03:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 49112f9
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-11 10:01:03 +0000
Message : Merge pull request #311 from mkcor/add-loading-section

Create section about image loading.
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
Auto-generated via {sandpaper}
Source  : 9cc0929
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-11 10:03:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 49112f9
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-11 10:01:03 +0000
Message : Merge pull request #311 from mkcor/add-loading-section

Create section about image loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Loading" as a separate section
3 participants