-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram episode corrections #312
Histogram episode corrections #312
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-312 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-12-08 15:17:47 +0000 |
@@ -351,10 +350,10 @@ with the | |||
function call, | |||
and then add a histogram line of the correct colour to the plot with the | |||
|
|||
`plt.plot(bin_edges[0:-1], histogram, color=c)` | |||
`plt.plot(bin_edges[0:-1], histogram, color=color)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified to be consistent with previous text and code
66ceb4a
to
e1032b9
Compare
Auto-generated via {sandpaper} Source : 2b4a521 Branch : main Author : Toby Hodges <[email protected]> Time : 2023-12-08 15:19:39 +0000 Message : Merge pull request #312 from bear-rsg/histogram-episode-corrections Histogram episode corrections
Auto-generated via {sandpaper} Source : 7197e9e Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-12-08 15:20:51 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2b4a521 Branch : main Author : Toby Hodges <[email protected]> Time : 2023-12-08 15:19:39 +0000 Message : Merge pull request #312 from bear-rsg/histogram-episode-corrections Histogram episode corrections
A couple of corrections and minor suggestions for the histogram episode :)