Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changes #318

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

JeremyPike
Copy link
Contributor

@JeremyPike JeremyPike commented Dec 18, 2023

These changes were requested by @mkcor in a review of #316 (already closed)

Ive added an explanation for plt.axis("off");

Copy link

github-actions bot commented Dec 18, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-318

The following changes were observed in the rendered markdown documents:

 08-connected-components.md | 22 ++++++++++++++++------
 md5sum.txt                 |  2 +-
 2 files changed, 17 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-18 15:46:02 +0000

github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
@JeremyPike JeremyPike marked this pull request as ready for review December 18, 2023 13:05
@tobyhodges
Copy link
Member

Requesting a review from @mkcor

Copy link
Contributor

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @JeremyPike!

episodes/08-connected-components.md Outdated Show resolved Hide resolved
Co-authored-by: Marianne Corvellec <[email protected]>
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
@tobyhodges tobyhodges merged commit 5224322 into datacarpentry:main Dec 19, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Dec 26, 2023
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Jan 28, 2024
Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Jan 28, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
Auto-generated via {sandpaper}
Source  : aad9cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-12-19 13:26:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request #318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Jan 30, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
@JeremyPike JeremyPike deleted the connected-components-changes branch February 2, 2024 10:23
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Feb 13, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Feb 20, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Feb 27, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
github-actions bot pushed a commit to uschille/image-processing that referenced this pull request Mar 5, 2024
Auto-generated via {sandpaper}
Source  : 384b460
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-28 20:27:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5224322
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2023-12-19 13:25:09 +0000
Message : Merge pull request datacarpentry#318 from bear-rsg/connected-components-changes

Review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants