Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler solution for wellplate exercise #323

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

JeremyPike
Copy link
Contributor

@JeremyPike JeremyPike commented Apr 30, 2024

This PR contains a couple minor suggestions and a simpler solution to the wellplate exercise which uses np.loadtxt() to load the .txt file containing the well coordinates. In my experience this has been much easier for learners to understand. Let me know what you think :)

Copy link

github-actions bot commented Apr 30, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-323

The following changes were observed in the rendered markdown documents:

 02-image-basics.md   | 10 +++++-----
 03-skimage-images.md |  2 ++
 04-drawing.md        | 26 +++++++++++++++-----------
 md5sum.txt           |  6 +++---
 4 files changed, 25 insertions(+), 19 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-30 15:01:19 +0000

@@ -436,7 +436,7 @@ a mapped continuum of intensities: greyscale.

```python
fig, ax = plt.subplots()
ax.imshow(three_colours,cmap=plt.cm.gray)
ax.imshow(three_colours, cmap="gray")
Copy link
Contributor Author

@JeremyPike JeremyPike Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the rest of the material

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Copy link
Contributor

@uschille uschille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request @JeremyPike - 👍 for np.loadtxt from me

@tobyhodges tobyhodges merged commit 877baa5 into datacarpentry:main Jun 7, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
Auto-generated via {sandpaper}
Source  : 877baa5
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-06-07 06:30:08 +0000
Message : Merge pull request #323 from bear-rsg/second-workshork-changes

Simpler solution for wellplate exercise
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
Auto-generated via {sandpaper}
Source  : 921f797
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-07 06:31:00 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 877baa5
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-06-07 06:30:08 +0000
Message : Merge pull request #323 from bear-rsg/second-workshork-changes

Simpler solution for wellplate exercise
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : 921f797
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-07 06:31:00 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 877baa5
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-06-07 06:30:08 +0000
Message : Merge pull request #323 from bear-rsg/second-workshork-changes

Simpler solution for wellplate exercise
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : 921f797
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-07 06:31:00 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 877baa5
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-06-07 06:30:08 +0000
Message : Merge pull request #323 from bear-rsg/second-workshork-changes

Simpler solution for wellplate exercise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants