Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #374. Thanks to @sstevens2 #414

Merged

Conversation

albhasan
Copy link
Contributor

@albhasan albhasan commented May 1, 2023

This PR removes an unnecessary NA filter and also an unnecessary cast to factor from Challenge: Plot Lines by Attribute (episode Explore and Plot by Vector Layer Attributes) as reportec by @sstevens2 in issue #374.

Fixes #374. Thanks to @sstevens2.

@github-actions
Copy link

github-actions bot commented May 1, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-414

The following changes were observed in the rendered markdown documents:

 07-vector-shapefile-attributes-in-r.md             |   40 +-
 config.yaml (gone)                                 |   92 --
 ...integration-rendered-compare-data-extents-1.png |  Bin 35077 -> 35147 bytes
 ...tion-rendered-repeat-compare-data-extents-1.png |  Bin 35077 -> 35147 bytes
 md5sum.txt                                         |   50 +-
 renv.lock (gone)                                   | 1005 --------------------
 6 files changed, 39 insertions(+), 1148 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-01 22:02:11 +0000

github-actions bot pushed a commit that referenced this pull request May 1, 2023
@drakeasberry
Copy link
Contributor

Thanks for integrating this change @albhasan and thanks for pointing out the issue @sstevens2.

@drakeasberry drakeasberry merged commit 5f66793 into datacarpentry:main Aug 2, 2023
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
Auto-generated via {sandpaper}
Source  : 5f66793
Branch  : main
Author  : Drake Asberry <[email protected]>
Time    : 2023-08-02 03:22:51 +0000
Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge

Fixes #374. Thanks to @sstevens2
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
Auto-generated via {sandpaper}
Source  : ced4cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-02 03:26:01 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5f66793
Branch  : main
Author  : Drake Asberry <[email protected]>
Time    : 2023-08-02 03:22:51 +0000
Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge

Fixes #374. Thanks to @sstevens2
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
Auto-generated via {sandpaper}
Source  : ced4cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-02 03:26:01 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5f66793
Branch  : main
Author  : Drake Asberry <[email protected]>
Time    : 2023-08-02 03:22:51 +0000
Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge

Fixes #374. Thanks to @sstevens2
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
Auto-generated via {sandpaper}
Source  : ced4cee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-02 03:26:01 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5f66793
Branch  : main
Author  : Drake Asberry <[email protected]>
Time    : 2023-08-02 03:22:51 +0000
Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge

Fixes #374. Thanks to @sstevens2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot Lines by Attribute Challenge Extra Steps
2 participants