-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #374. Thanks to @sstevens2 #414
Fixes #374. Thanks to @sstevens2 #414
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-414 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-05-01 22:02:11 +0000 |
Thanks for integrating this change @albhasan and thanks for pointing out the issue @sstevens2. |
Auto-generated via {sandpaper} Source : 5f66793 Branch : main Author : Drake Asberry <[email protected]> Time : 2023-08-02 03:22:51 +0000 Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge Fixes #374. Thanks to @sstevens2
Auto-generated via {sandpaper} Source : ced4cee Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-08-02 03:26:01 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5f66793 Branch : main Author : Drake Asberry <[email protected]> Time : 2023-08-02 03:22:51 +0000 Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge Fixes #374. Thanks to @sstevens2
Auto-generated via {sandpaper} Source : ced4cee Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-08-02 03:26:01 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5f66793 Branch : main Author : Drake Asberry <[email protected]> Time : 2023-08-02 03:22:51 +0000 Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge Fixes #374. Thanks to @sstevens2
Auto-generated via {sandpaper} Source : ced4cee Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-08-02 03:26:01 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5f66793 Branch : main Author : Drake Asberry <[email protected]> Time : 2023-08-02 03:22:51 +0000 Message : Merge pull request #414 from albhasan/plot_lines_by_attribute_challenge Fixes #374. Thanks to @sstevens2
This PR removes an unnecessary NA filter and also an unnecessary cast to factor from
Challenge: Plot Lines by Attribute
(episodeExplore and Plot by Vector Layer Attributes
) as reportec by @sstevens2 in issue #374.Fixes #374. Thanks to @sstevens2.