Issue #1753 remove non CE features #1759
Conversation
|
Whoah, that's a LOOOOT of code removed. I'll start digging :) (I should probably check the branch out for the code review, so I can see the tree properly. I guess it looks more crazy in list form, because whole modules has been nuked, and those I can essentially ignore completely as long as I agree with the module removal itself) |
|
Just curious: Any reason for the fork instead of a branch (same with the other PR), just habit? :) |
|
With OSS projects I like to use forks so as to not needlessly exercise my administrative privileges, but rather go through the "contributor" experience ;-) |
|
Hmmmm... My internal pedant wants to point out that it's not administrative privileges, but makes sense :) |
|
Do we really want to get rid of the ExtensionSwap? I realize that it'll need to be reworked with an internal UI (e.g. using something like a simple GitHub-pages hosted JSON that links to the extensions, which could in most cases simply be release files in GitHub), but it seems like a bit of a shame to completely lose it. OTOH, if anyone does that work, s/he'd probably have to start all over anyway, and we still have the base extension loading, so it's probably all good. BTW, you left in the "Browse the ExtensionSwap" menu item in options/Extensions, was that on purpose? |
| @@ -32,7 +32,6 @@ | |||
| import org.apache.commons.lang.ArrayUtils; | |||
| import org.apache.metamodel.util.Action; | |||
| import org.datacleaner.actions.DownloadFilesActionListener; | |||
| import org.datacleaner.actions.PublishResultToMonitorActionListener; | |||
There was a problem hiding this comment.
There's a reference to this class in the JavaDoc below
| * needed. | ||
| */ | ||
| @Deprecated | ||
| public static <K, V> ConcurrentMap<K, V> createCacheMap() { |
There was a problem hiding this comment.
ConcurrentMap is now an unused import
|
LGTM! |
Fixes #1753
This is a rather aggressive cleanup in our codebase to remove non-CE relevant code. Here's a listing of stuff I removed (got my hands proper dirty this time so I hope I remember all):