Added spark driver info to UI with alerts #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menishmueli
requested changes
Sep 17, 2024
spark-plugin/plugin/src/main/scala/org/apache/spark/dataflint/listener/model.scala
Show resolved
Hide resolved
spark-plugin/plugin/src/main/scala/org/apache/spark/dataflint/DataflintSparkUILoader.scala
Outdated
Show resolved
Hide resolved
DanielAronovich
force-pushed
the
feature/add_driver_memory_usage_to_UI
branch
from
af13c7a
to
2c2ee4e
Compare
menishmueli
requested changes
Sep 23, 2024
| </Typography> | ||
| <Typography variant="subtitle2"> | ||
| "Memory Usage" is the peak memory usage of the most | ||
| <Typography variant="body1" color="inherit" textAlign={"center"}> |
There was a problem hiding this comment.
when no data please hide the text
| ); | ||
| const driverMaxMemory = environmentInfo?.driverXmxBytes ?? 1; | ||
| const driverMemoryUsage = driverExecutor?.memoryUsageBytes ?? 0; | ||
| const driverMemoryUsagePercentage = |
There was a problem hiding this comment.
please use the calculatePercentage util I wrote
| else (listener: SparkListenerInterface, queue: String) => context.listenerBus.addToQueue(listener, queue) | ||
| addToQueueMethod(dataflintListener, "dataflint") | ||
| context.listenerBus.post(DataflintEnvironmentInfoEvent(environmentInfo)) | ||
| logInfo(s"Posted DataflintEnvironmentInfoEvent max driver memory: ${driverXmxBytes}") |
There was a problem hiding this comment.
please remove this log line from production
| logInfo(s"Posted DataflintEnvironmentInfoEvent max driver memory: ${driverXmxBytes}") | ||
| if (isDatabricks) { | ||
| addToQueueMethod(DataflintDatabricksLiveListener(context.listenerBus), "dataflint") | ||
| logInfo("Added DataflintDatabricksLiveListener to the Spark context") |
There was a problem hiding this comment.
please remove this line from production
| ? Object.values(executors).find((exec) => exec.id === "driver") | ||
| : undefined; | ||
| const driverMaxMemory = environmentInfo?.driverXmxBytes ?? 1; | ||
| const driverMemoryUsage = driverExecutor?.memoryUsageBytes ?? 0; |
There was a problem hiding this comment.
please change memoryUsageBytes to use only on heap memory (+ executors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added spark driver info to the memory usage in the status and summary tabs
Added relevant alerts for driver over usage