Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments break parsing if they are part of normal line #36

Closed
KoBeWi opened this issue Apr 5, 2021 · 0 comments
Closed

Comments break parsing if they are part of normal line #36

KoBeWi opened this issue Apr 5, 2021 · 0 comments

Comments

@KoBeWi
Copy link

KoBeWi commented Apr 5, 2021

Looks like comments are ignored only if they start the line. In my file I did something like

[Some group];some comment

and it wasn't parsed correctly as a group.

It should be possible to put comments in regular lines, in which case they should be just trimmed out from the end.
jasonwbarnett added a commit to jasonwbarnett/ruby-parseconfig that referenced this issue Apr 12, 2021
@jasonwbarnett
Fix datafolklabs#36
38944c2
jasonwbarnett added a commit to jasonwbarnett/ruby-parseconfig that referenced this issue Apr 12, 2021
@jasonwbarnett
Fix datafolklabs#36
3e5b938
dmitryshagin added a commit that referenced this issue Sep 30, 2021
@dmitryshagin
Merge pull request #37 from jasonwbarnett/fix-comment-issue
dae22ab 
Fix #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KoBeWi