Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix returning of values vs array #43

Conversation

adriangb
Copy link
Collaborator

@adriangb adriangb commented Sep 8, 2024

No description provided.

@adriangb
Copy link
Collaborator Author

adriangb commented Sep 8, 2024

From @samuelcolvin:

we're using dict.values() in datafusion-functions-json then just returning that array, I'm a bit concerned that the arrays return are going to be the wrong length (and intend generally wrong), e.g. that they're using the just the unique values, not the full array

I think this should fix it. I wasn't able to get the existing tests to fail, I thought I would be able to by adding a repeated key but couldn't, but this new test does fail on the target branch:

UDF returned a different number of rows than expected. Expected: 7, Got: 4

Cargo.toml Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Collaborator

A lot of the diff doesn't seem related to this change?

@adriangb
Copy link
Collaborator Author

adriangb commented Sep 8, 2024

A lot of the diff doesn't seem related to this change?
Yeah not sure why cargo fmt or clippy did that, but it does seem correct so maybe lets just merge it...

@adriangb
Copy link
Collaborator Author

adriangb commented Sep 8, 2024

@samuelcolvin should we merge this?

@samuelcolvin samuelcolvin merged commit 3767061 into datafusion-contrib:allow-json-contains-filter Sep 9, 2024
7 checks passed
@samuelcolvin
Copy link
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants