Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SQLite from writing incomplete data on transition errors #101

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

sgrebnov
Copy link
Collaborator

@sgrebnov sgrebnov commented Sep 15, 2024

If a data stream fails (for example, if the connection to the federated dataset is closed), we should not write incomplete data to SQLite.

@sgrebnov sgrebnov changed the title Prevent SQLite from writing incomplete data on errors Prevent SQLite from writing incomplete data on transition errors Sep 15, 2024
@phillipleblanc phillipleblanc merged commit 54dbc18 into spiceai Sep 15, 2024
3 checks passed
@phillipleblanc phillipleblanc deleted the sgrebnov/sqlite-fix branch September 15, 2024 06:02
@sgrebnov sgrebnov self-assigned this Sep 15, 2024
hozan23 pushed a commit to hozan23/datafusion-table-providers that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants