Ignore CHECKPOINT errors for DuckDB

src/duckdb.rs

@@ -90,11 +90,6 @@ pub enum Error {
     #[snafu(display("Unable to commit transaction: {source}"))]
     UnableToCommitTransaction { source: duckdb::Error },
 
-    #[snafu(display("Unable to checkpoint duckdb: {source}"))]
-    UnableToCheckpoint {
-        source: Box<dyn std::error::Error + Send + Sync>,
-    },
-
     #[snafu(display("Unable to begin duckdb transaction: {source}"))]
     UnableToBeginTransaction { source: duckdb::Error },
 

src/duckdb/write.rs

@@ -214,12 +214,15 @@ impl DataSink for DuckDBDataSink {
 
         match duckdb_write_handle.await {
             Ok(result) => {
-                // before returning the result, CHECKPOINT to flush the WAL to disk
+                // before returning the result, attempt to CHECKPOINT to flush the WAL to disk
                 let mut conn = self.duckdb.connect_sync().map_err(to_datafusion_error)?;
                 let conn = DuckDB::duckdb_conn(&mut conn).map_err(to_datafusion_error)?;
-                conn.execute("CHECKPOINT", &[]).map_err(|err| {
-                    to_datafusion_error(super::Error::UnableToCheckpoint { source: err })
-                })?;
+
+                // This may fail if multiple transactions are active (i.e. actively writing data)
+                // we can ignore the error since it will be written once the last transaction finishes.
+                if let Err(e) = conn.execute("CHECKPOINT", &[]) {
+                    tracing::trace!("DuckDB CHECKPOINT failed - this is expected if there are multiple active transactions: {e}");
+                };
 
                 result
             }