Handle inconsistent scale in Postgres Numeric Type data #110
+89
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sevenannn
changed the title
lukekim
reviewed
Sep 18, 2024
lukekim
reviewed
Sep 18, 2024
Co-authored-by: Luke Kim <[email protected]>
…/datafusion-table-providers into qianqian/fix-pg-double
sgrebnov
approved these changes
Sep 19, 2024
hozan23
pushed a commit
to hozan23/datafusion-table-providers
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres
numerictype doesn't necessarily contain value with same scale, while arrow decimal type has a fixed scale, update the row -> arrow conversion to resolve scale difference across rows, and add a test to verify the fix.