Add sqlite_busytimeout parameter as user configurable param #121
+79
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekim
reviewed
Sep 28, 2024
lukekim
approved these changes
Sep 28, 2024
This was referenced Sep 28, 2024
phillipleblanc
approved these changes
Sep 30, 2024
hozan23
pushed a commit
to hozan23/datafusion-table-providers
that referenced
this pull request
Oct 11, 2024
…on-contrib#121) * Add sqlite_busytimeout parameter as user configurable param * Remove debug log * Fix lint, fix integration test --------- Co-authored-by: Phillip LeBlanc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sqlite busy_timeout parameter as user configurable param, this allows for more flexibility when having multiple writes into the single sqlite instance, as sqlite has file level locking that only permits one write at a time. The
busy_timeoutconfiguration allows for the writes that are waiting to obtain lock to wait for the duration specified bybusy_timeoutbefore reporting errorRuSqlite: Database is locked