Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reuse write pool for in-memory SQLite #27

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Aug 2, 2024

🗣 Description

  • Reuses the write connection pool for in-memory SQLite databases

If we spin up a new connection pool, we create a different in-memory database so the read provider isn't reading the same database anymore.

  • Updates connection PRAGMA configuration to only execute for file mode SQLite databases

In-memory SQLite databases don't support WAL journal mode, so let's not try to apply it. The other tuning parameters also don't make sense for in-memory databases.

@phillipleblanc phillipleblanc merged commit 2870827 into datafusion-contrib:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants