fix: Support INTERVAL in SQLite
#85
Merged
+498
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring the parser
phillipleblanc
approved these changes
Sep 4, 2024
phillipleblanc
added a commit
that referenced
this pull request
Sep 4, 2024
* wip * duckdb streaming * clippy * arrow to arrow stream * error message * fix: Support `INTERVAL` in SQLite (#85) * poc: Support interval in SQLite using an AST analyzer * Refactoring * u64 -> i64 * fix: Support INTERVAL expressions in SQLite * docs: Add comment about flattening arguments list * refactor: Rename SQLiteVisitor to SQLiteIntervalVisitor * test: Add some tests --------- Co-authored-by: Phillip LeBlanc <[email protected]> * Use DuckDB streaming * Fixes * Fix feature flagging * Fix lint * Add spiceai branch to pull_request --------- Co-authored-by: peasee <[email protected]> Co-authored-by: Phillip LeBlanc <[email protected]>
hozan23
pushed a commit
to hozan23/datafusion-table-providers
that referenced
this pull request
Sep 19, 2024
* wip * duckdb streaming * clippy * arrow to arrow stream * error message * fix: Support `INTERVAL` in SQLite (datafusion-contrib#85) * poc: Support interval in SQLite using an AST analyzer * Refactoring * u64 -> i64 * fix: Support INTERVAL expressions in SQLite * docs: Add comment about flattening arguments list * refactor: Rename SQLiteVisitor to SQLiteIntervalVisitor * test: Add some tests --------- Co-authored-by: Phillip LeBlanc <[email protected]> * Use DuckDB streaming * Fixes * Fix feature flagging * Fix lint * Add spiceai branch to pull_request --------- Co-authored-by: peasee <[email protected]> Co-authored-by: Phillip LeBlanc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
ast_analzyerfor SQLite, using anSQLiteIntervalVisitorto walk the AST and replaceINTERVALexpressions with their relevantdate()ordatetime()expressions for date comparisons because SQLite does not natively supportINTERVAL.