fix: Don't silence blocking task errors #91
Merged
+32
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
reviewed
Sep 10, 2024
sgrebnov
approved these changes
Sep 10, 2024
phillipleblanc
approved these changes
Sep 10, 2024
hozan23
pushed a commit
to hozan23/datafusion-table-providers
that referenced
this pull request
Sep 19, 2024
* fix: Don't silence blocking task errors * fix: Cover Ok(Err()) match arm for DuckDB writer handle * refactor: Rename overloaded error e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
JoinHandleisResult<T, JoinError>. If the inner blocking tasks return aResult<>themselves, we need to ensure we match forOk(Err(e)to get the inner error, orErr(e)to get theJoinError.