Skip to content

Commit

Permalink
fix(docs,build): remove base image not needed, cleanup docs (#5469)
Browse files Browse the repository at this point in the history
  • Loading branch information
anshbansal authored Jul 22, 2022
1 parent 0455ae0 commit 935b423
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 89 deletions.
26 changes: 0 additions & 26 deletions .github/workflows/docker-ingestion-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,29 +41,3 @@ jobs:
platforms: linux/amd64,linux/arm64
tags: acryldata/datahub-ingestion-base:latest
push: true

build-base-jdk:
name: Build and Push Docker Image to Docker Hub
runs-on: ubuntu-latest
steps:
- name: Check out the repo
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
- name: Login to DockerHub
uses: docker/login-action@v1
with:
username: ${{ secrets.ACRYL_DOCKER_USERNAME }}
password: ${{ secrets.ACRYL_DOCKER_PASSWORD }}
- name: Build and Push image
uses: docker/build-push-action@v2
with:
context: ./docker/datahub-ingestion
file: ./docker/datahub-ingestion/base-jdk8.Dockerfile
platforms: linux/amd64,linux/arm64
tags: acryldata/datahub-ingestion-base:latest-jdk8
push: true
70 changes: 13 additions & 57 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,19 @@ You can easily download and run all these images and their dependencies with our

DataHub Docker Images:

* [linkedin/datahub-ingestion](https://hub.docker.com/r/linkedin/datahub-ingestion/tags?page=1&name=v) - This contains the Python CLI. If you are looking for docker image for every minor CLI release you can find them under [acryldata/datahub-ingestion](https://hub.docker.com/r/acryldata/datahub-ingestion/tags?page=1&name=v)
* [linkedin/datahub-gms](https://cloud.docker.com/repository/docker/linkedin/datahub-gms/)
* [linkedin/datahub-frontend-react](https://cloud.docker.com/repository/docker/linkedin/datahub-frontend-react/)
* [linkedin/datahub-mae-consumer](https://cloud.docker.com/repository/docker/linkedin/datahub-mae-consumer/)
* [linkedin/datahub-mce-consumer](https://cloud.docker.com/repository/docker/linkedin/datahub-mce-consumer/)
Do not use `latest` or `debug` tags for any of the image as those are not supported and present only due to leagcy reasons. Please use `head` or tags specific for versions like `v0.8.40`. For production we recommend using version specific tags not `head`.

* [linkedin/datahub-ingestion](https://hub.docker.com/r/linkedin/datahub-ingestion/) - This contains the Python CLI. If you are looking for docker image for every minor CLI release you can find them under [acryldata/datahub-ingestion](https://hub.docker.com/r/acryldata/datahub-ingestion/).
* [linkedin/datahub-gms](https://hub.docker.com/repository/docker/linkedin/datahub-gms/).
* [linkedin/datahub-frontend-react](https://hub.docker.com/repository/docker/linkedin/datahub-frontend-react/)
* [linkedin/datahub-mae-consumer](https://hub.docker.com/repository/docker/linkedin/datahub-mae-consumer/)
* [linkedin/datahub-mce-consumer](https://hub.docker.com/repository/docker/linkedin/datahub-mce-consumer/)
* [acryldata/datahub-upgrade](https://hub.docker.com/r/acryldata/datahub-upgrade/)
* [linkedin/datahub-kafka-setup](https://hub.docker.com/r/acryldata/datahub-kafka-setup/)
* [linkedin/datahub-elasticsearch-setup](https://hub.docker.com/r/linkedin/datahub-elasticsearch-setup/)
* [acryldata/datahub-mysql-setup](https://hub.docker.com/r/acryldata/datahub-mysql-setup/)
* [acryldata/datahub-postgres-setup](https://hub.docker.com/r/acryldata/datahub-postgres-setup/)
* [acryldata/datahub-actions](https://hub.docker.com/r/acryldata/datahub-actions). Do not use `acryldata/acryl-datahub-actions` as that is deprecated and no longer used.

Dependencies:
* [Kafka, Zookeeper, and Schema Registry](kafka-setup)
Expand Down Expand Up @@ -62,55 +70,3 @@ COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 docker-compose -p datahub build
This is because we're relying on builtkit for multistage builds. It does not hurt also set `DATAHUB_VERSION` to
something unique.

## Ember
To serve the legacy Ember UI, follow the instructions below.

> **Before continuing**: If you've already run a deploy script, don't forget to clear containers using `docker container prune`
### Serving Ember Only

#### All Containers

Use the `quickstart-ember.sh` script to launch all containers in DataHub, including a frontend server that serves the Ember UI
```
./quickstart-ember.sh
```

#### The Bare Minimum
Run the following command to launch only the Ember server and its required dependencies

```
docker-compose -f docker-compose.ember.yml -f docker-compose.yml -f docker-compose.override.yml up datahub-frontend-ember
```

Once complete, navigate to `localhost:9001` in your browser to see the legacy Ember app.

### Serving React + Ember
If you'd like to serve the React and Ember UIs side-by-side, you can deploy the `datahub-frontend-ember` service manually.

#### All Containers

To deploy all DataHub containers, run the quickstart script:
```
./quickstart.sh
```

Next, deploy the container that serves the Ember UI:

```
docker-compose -f docker-compose.ember.yml -f docker-compose.yml -f docker-compose.override.yml up --no-deps datahub-frontend-ember
```

#### The Bare Minimum
First, start the React frontend server & its required dependencies:

```
docker-compose up datahub-frontend-react
```

Then, start the Ember frontend server & its required dependencies:
```
docker-compose -f docker-compose.ember.yml -f docker-compose.yml -f docker-compose.override.yml up datahub-frontend-ember
```

Navigate to `localhost:9002/` to view the React app & `localhost:9001/` to view the legacy Ember app.
6 changes: 0 additions & 6 deletions docker/datahub-ingestion/base-jdk8.Dockerfile

This file was deleted.

0 comments on commit 935b423

Please sign in to comment.