Skip to content

Commit

Permalink
chore(react): remove outdated cypress tests and dependency (#6948)
Browse files Browse the repository at this point in the history
  • Loading branch information
anshbansal authored Jan 5, 2023
1 parent b48e503 commit c9626bd
Show file tree
Hide file tree
Showing 12 changed files with 28 additions and 537 deletions.
10 changes: 3 additions & 7 deletions datahub-web-react/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,11 @@ Optionally you could also start the app with the mock server without running the

### Functional testing

Automated functional testing is powered by Cypress and MirageJS. When running the web server with Cypress the port is set to 3010 so that the usual web server running on port 3000 used for development can be started without interruptions.
In order to start a server and run frontend unit tests using react-testing-framework, run:

#### During development
`yarn test :e2e`

`yarn test:e2e`

#### CI

`yarn test:e2e:ci`
There are also more automated tests using Cypress in the `smoke-test` folder of the repository root.

#### Troubleshooting
`Error: error:0308010C:digital envelope routines::unsupported`: This error message shows up when using Node 17, due to an OpenSSL update related to md5.
Expand Down
4 changes: 0 additions & 4 deletions datahub-web-react/cypress.json

This file was deleted.

12 changes: 0 additions & 12 deletions datahub-web-react/cypress/.eslintrc.js

This file was deleted.

5 changes: 0 additions & 5 deletions datahub-web-react/cypress/fixtures/example.json

This file was deleted.

11 changes: 0 additions & 11 deletions datahub-web-react/cypress/helper/authHelper.ts

This file was deleted.

40 changes: 0 additions & 40 deletions datahub-web-react/cypress/integration/Login.spec.ts

This file was deleted.

36 changes: 0 additions & 36 deletions datahub-web-react/cypress/integration/Search.spec.ts

This file was deleted.

47 changes: 0 additions & 47 deletions datahub-web-react/cypress/plugins/index.js

This file was deleted.

20 changes: 0 additions & 20 deletions datahub-web-react/cypress/support/index.js

This file was deleted.

10 changes: 0 additions & 10 deletions datahub-web-react/cypress/tsconfig.json

This file was deleted.

7 changes: 1 addition & 6 deletions datahub-web-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"@ant-design/icons": "^4.3.0",
"@apollo/client": "^3.3.19",
"@craco/craco": "^6.1.1",
"@cypress/webpack-preprocessor": "5.8.0",
"@data-ui/xy-chart": "^0.0.84",
"@miragejs/graphql": "^0.1.11",
"@monaco-editor/react": "^4.3.1",
Expand Down Expand Up @@ -50,7 +49,6 @@
"color-hash": "^2.0.1",
"craco-antd": "^1.19.0",
"cronstrue": "^1.122.0",
"cypress": "7.3.0",
"d3-scale": "^3.3.0",
"d3-time-format": "^3.0.0",
"deepmerge": "^4.2.2",
Expand Down Expand Up @@ -104,11 +102,8 @@
"ec2-dev": "yarn run generate && CI=true;export CI;BROWSER=none craco start",
"build": "yarn run generate && CI=false REACT_APP_MOCK=false craco build && rm -rf dist/ && cp -r build/yarn/ dist/ && rm -r build/yarn/",
"test": "craco test",
"cy:run:ci": "cypress run",
"pretest:e2e:ci": "yarn generate",
"test:e2e:ci": "start-server-and-test start:e2e 3010 cy:run:ci",
"cy:open": "cypress open",
"test:e2e": "start-server-and-test start:e2e 3010 cy:open",
"test:e2e": "start-server-and-test start:e2e 3010",
"eject": "react-scripts eject",
"generate": "graphql-codegen --config codegen.yml",
"lint": "eslint . --ext .ts,.tsx --quiet",
Expand Down
Loading

0 comments on commit c9626bd

Please sign in to comment.