fix(ingest/unity): simplify MCP generation and reporting (#6911)

Co-authored-by: John Joyce <[email protected]>
datahub-project · Jan 5, 2023 · feaab3b · feaab3b
1 parent f651646
commit feaab3b
Show file tree

Hide file tree

Showing 3 changed files with 109 additions and 178 deletions.
diff --git a/metadata-ingestion/src/datahub/emitter/mcp.py b/metadata-ingestion/src/datahub/emitter/mcp.py
@@ -1,6 +1,6 @@
 import dataclasses
 import json
-from typing import TYPE_CHECKING, Optional, Tuple, Union
+from typing import TYPE_CHECKING, List, Optional, Tuple, Union
 
 from datahub.emitter.aspect import ASPECT_MAP, TIMESERIES_ASPECT_MAP
 from datahub.emitter.serialization_helper import post_json_transform, pre_json_transform
@@ -99,6 +99,12 @@ def __post_init__(self) -> None:
                 f"aspectName {self.aspectName} does not match aspect type {type(self.aspect)} with name {self.aspect.get_aspect_name()}"
             )
 
+    @classmethod
+    def construct_many(
+        cls, entityUrn: str, aspects: List[Optional[_Aspect]]
+    ) -> List["MetadataChangeProposalWrapper"]:
+        return [cls(entityUrn=entityUrn, aspect=aspect) for aspect in aspects if aspect]
+
     def make_mcp(self) -> MetadataChangeProposalClass:
         serializedEntityKeyAspect: Union[None, GenericAspectClass] = None
         if isinstance(self.entityKeyAspect, DictWrapper):