fix(ingest): remove unused mysql golden file (#6106)

datahub-project · Oct 5, 2022 · feb9d59 · feb9d59
1 parent ee1a1ef
commit feb9d59
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2,039 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/two_tier_sql_source.py b/metadata-ingestion/src/datahub/ingestion/source/sql/two_tier_sql_source.py
@@ -51,12 +51,12 @@ def get_sql_alchemy_url(
 class TwoTierSQLAlchemySource(SQLAlchemySource):
     def __init__(self, config, ctx, platform):
         super().__init__(config, ctx, platform)
-        self.current_database = None
         self.config: TwoTierSQLAlchemyConfig = config
 
     def get_parent_container_key(self, db_name: str, schema: str) -> PlatformKey:
         # Because our overridden get_allowed_schemas method returns db_name as the schema name,
         # the db_name and schema here will be the same. Hence, we just ignore the schema parameter.
+        assert db_name == schema
         return self.gen_database_key(db_name)
 
     def get_allowed_schemas(
@@ -66,6 +66,10 @@ def get_allowed_schemas(
         # dbName itself as an allowed schema
         yield db_name
 
+    def gen_schema_key(self, db_name: str, schema: str) -> PlatformKey:
+        # Sanity check that we don't try to generate schema containers for 2 tier databases.
+        raise NotImplementedError
+
     def get_inspectors(self):
         # This method can be overridden in the case that you want to dynamically
         # run on multiple databases.
@@ -84,7 +88,6 @@ def get_inspectors(self):
                     inspector = inspect(
                         create_engine(url, **self.config.options).connect()
                     )
-                    self.current_database = db
                     yield inspector
 
     def gen_schema_containers(