Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion/hive): ignore sampling for tagged column/table #10096

Merged
merged 3 commits into from
Apr 4, 2024
Merged

fix(ingestion/hive): ignore sampling for tagged column/table #10096

merged 3 commits into from
Apr 4, 2024

Conversation

dushayntAW
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 21, 2024
anshbansal
anshbansal reviewed Apr 3, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py Outdated
Comment on lines 1341 to 1350
dataset_urn = mce_builder.make_dataset_urn(
name=dataset_name, platform="hive", env="PROD"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py has hard-coded for hive and PROD?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in case some other source is used here? What happens in case someone uses a different env?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this generic, and not setting the hive hardcoded, have tested with MySQL and ignore sampling is working with MySQL as well

@anshbansal anshbansal marked this pull request as draft April 3, 2024 12:18
@dushayntAW dushayntAW marked this pull request as ready for review April 3, 2024 19:53
@anshbansal anshbansal merged commit bad96ed into datahub-project:master Apr 4, 2024
56 of 57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@dushayntAW @sleeperdeep
fix(ingestion/hive): ignore sampling for tagged column/table (datahub…
0ad941b 
…-project#10096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dushayntAW @anshbansal