-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql): Support START_WITH and END_WITH operator in GraphQL API #11026
feat(graphql): Support START_WITH and END_WITH operator in GraphQL API #11026
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes introduce two new operators, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- datahub-graphql-core/src/main/resources/search.graphql (1 hunks)
Additional comments not posted (2)
datahub-graphql-core/src/main/resources/search.graphql (2)
549-552
: Addition ofSTART_WITH
operator looks good.The
START_WITH
operator has been added correctly with a clear comment explaining its purpose.
554-557
: Addition ofEND_WITH
operator looks good.The
END_WITH
operator has been added correctly with a clear comment explaining its purpose.
Note that while I am not sure why it was excluded, I do see a performance warning on the implementation of those conditions here. |
@david-leifker caould you help us with the issue here. Build is failing for https://github.com/datahub-project/datahub/actions/runs/10155880526/job/28427095444?pr=11026#step:7:2288 should we retry this build again. |
@milindgupta9 - Please run From the logs: |
@david-leifker I ran ./gradlew spotlessApply --rerun-tasks in my local and it successfully passed. |
@david-leifker anything that I can do here as it doesn't seem to be the issue with linting errors. |
@david-leifker could you please help us here? |
Resolved the 1 conflict with the main branch, tests running..... |
Thanks David, I was not able to see these changes. Thanks for resolving them. |
Small PR for adding the start_with and end_with operator in GraphQL API
Checklist
Summary by CodeRabbit
START_WITH
andEND_WITH
) for enhanced string query capabilities in the GraphQL API, providing users with more flexibility in their search operations.