Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size #11051

Merged
merged 4 commits into from
Jul 31, 2024
Merged

feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size #11051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dca40e0
feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size
pedro93 Jul 31, 2024
2ec93a6
add docs
pedro93 Jul 31, 2024
f7f5843
Move limit to a constant
pedro93 Jul 31, 2024
8b387b7
Merge branch 'master' into feature/cus-2162
pedro93 Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/how/updating-datahub.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ profiling:
- #10498 - Tableau ingestion can now be configured to ingest multiple sites at once and add the sites as containers. The feature is currently only available for Tableau Server.
- #10466 - Extends configuration in `~/.datahubenv` to match `DatahubClientConfig` object definition. See full configuration in https://datahubproject.io/docs/python-sdk/clients/. The CLI should now respect the updated configurations specified in `~/.datahubenv` across its functions and utilities. This means that for systems where ssl certification is disabled, setting `disable_ssl_verification: true` in `~./datahubenv` will apply to all CLI calls.
- #11002 - We will not auto-generate a `~/.datahubenv` file. You must either run `datahub init` to create that file, or set environment variables so that the config is loaded.

- #11023 - Added a new parameter to datahub's `put` cli command: `--run-id`. This parameter is useful to associate a given write to an ingestion process. A use-case can be mimick transformers when a transformer for aspect being written does not exist.
- #11051 - Ingestion reports will now trim the summary text to a maximum of 800k characters to avoid generating `dataHubExecutionRequestResult` that are too large for GMS to handle.
## 0.13.3

### Breaking Changes
Expand Down
6 changes: 5 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/reporting/datahub_ingestion_run_summary_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
from datahub.utilities.logging_manager import get_log_buffer
from datahub.utilities.urns.urn import Urn


logger = logging.getLogger(__name__)


Expand All @@ -43,6 +44,7 @@ class DatahubIngestionRunSummaryProvider(PipelineRunListener):
_EXECUTOR_ID: str = "__datahub_cli_"
_EXECUTION_REQUEST_SOURCE_TYPE: str = "CLI_INGESTION_SOURCE"
_INGESTION_TASK_NAME: str = "CLI Ingestion"
_MAX_SUMMARY_SIZE: int = 800000

@staticmethod
def get_cur_time_in_ms() -> int:
Expand Down Expand Up @@ -209,7 +211,9 @@ def on_completion(
status=status,
startTimeMs=self.start_time_ms,
durationMs=self.get_cur_time_in_ms() - self.start_time_ms,
report=summary,
# Truncate summary such that the generated MCP will not exceed GMS's payload limit.
# Hardcoding the overall size of dataHubExecutionRequestResult to >1MB by trimming summary to 800,000 chars
report=summary[-self._MAX_SUMMARY_SIZE:],
structuredReport=structured_report,
)

Expand Down
Loading