Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validations): Ingest and metadata schema validators #11619

Merged
merged 6 commits into from
Oct 15, 2024
Merged

feat(validations): Ingest and metadata schema validators #11619

merged 6 commits into from
Oct 15, 2024

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Oct 14, 2024 •
edited
Loading

Adding additional validations:

  1. Schema field/column fieldPaths can no longer be an empty string
  2. Schema field/column fieldPaths can no longer include duplicates
  3. Certain ingestion results are considered immutable
    • EXECUTION_REQUEST_STATUS_ABORTED
    • EXECUTION_REQUEST_STATUS_CANCELLED
    • EXECUTION_REQUEST_STATUS_SUCCESS
    • EXECUTION_REQUEST_STATUS_DUPLICATE

Builds from #10477

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker david-leifker changed the title feat(validations): Ingest and schema validators feat(validations): Ingest and metadata schema validators Oct 14, 2024
@david-leifker david-leifker mentioned this pull request Oct 14, 2024
Closed
5 tasks
@david-leifker david-leifker force-pushed the ingest-and-schema-validators branch 2 times, most recently from bb2f90c to 6f0313e Compare October 15, 2024 11:36
@david-leifker david-leifker mentioned this pull request Oct 15, 2024
Closed
5 tasks
@david-leifker david-leifker merged commit 5d3e464 into datahub-project:master Oct 15, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-leifker @RyanHolstien @pedro93