Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(extractor): Move extractors to entity-registry #4307

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

The extractors do not need any extra dependencies in metadata-io. Move them to entity-registry so that it can be included in datahub-client library

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Unit Test Results (build & test)

  71 files    71 suites   17m 3s ⏱️
618 tests 559 ✔️ 59 💤 0

Results for commit 688bc50.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit daab31d into datahub-project:master Mar 4, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--move-extractors branch March 4, 2022 00:57
@dexter-mh-lee dexter-mh-lee restored the dl--move-extractors branch March 14, 2022 21:17
@dexter-mh-lee dexter-mh-lee deleted the dl--move-extractors branch April 4, 2022 23:47
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
…ect#4307)

* Move extractors to entity-registry

* Fix test

* Fix checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants