Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Correct display name for users in UI #4323

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Fallback to the normal username if a display name does not exist. Do not default to None.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

Unit Test Results (build & test)

  76 files  ±0    76 suites  ±0   9m 32s ⏱️ - 12m 9s
630 tests ±0  571 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 188d2b9. ± Comparison against base commit 787a7e6.

@shirshanka shirshanka merged commit b48b215 into datahub-project:master Mar 5, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants