fix(removed): Make sure removed entities do not appear on recommendations #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 8, 2022 17:10
jjoyce0510
reviewed
Mar 11, 2022
| @@ -106,7 +110,7 @@ private SearchRequest buildSearchRequest(@Nonnull Urn userUrn) { | |||
| // Find the entities with the most views | |||
| AggregationBuilder aggregation = AggregationBuilders.terms(ENTITY_AGG_NAME) | |||
| .field(DataHubUsageEventConstants.ENTITY_URN + ESUtils.KEYWORD_SUFFIX) | |||
| .size(MAX_CONTENT); | |||
| .size(MAX_CONTENT * 2); | |||
There was a problem hiding this comment.
Curious - why this change necessary?
There was a problem hiding this comment.
so that after filtering we still have the num left
shirshanka
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also apply removed filter on the metadata analytics charts.
Checklist