Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): rename SAP HANA source and data platform #5043

Merged

Conversation

Masterchen09
Copy link
Contributor

It is probably way too nitpicky, but SAP's HANA is called SAP HANA and not SAP Hana or Hana. 😁

https://www.sap.com/products/hana.html

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

Unit Test Results (build & test)

  77 files    77 suites   2m 56s ⏱️
333 tests 333 ✔️ 0 💤 0

Results for commit afaab53.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   1h 23m 54s ⏱️ - 7m 12s
   551 tests ±  0     548 ✔️ ±  0    3 💤 ±  0  0 ±0 
2 532 runs  +62  2 459 ✔️ +94  73 💤  - 32  0 ±0 

Results for commit afaab53. ± Comparison against base commit 1a31f788.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@shirshanka shirshanka merged commit 2a373c2 into datahub-project:master May 31, 2022
@Masterchen09 Masterchen09 deleted the fix-hana-display-name branch May 31, 2022 22:13
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@Masterchen09 Masterchen09 mentioned this pull request Feb 5, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants