Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): bigquery - Graceful bq partition id date parsing failure #5386

Merged
merged 3 commits into from
Jul 13, 2022
Merged

fix(ingest): bigquery - Graceful bq partition id date parsing failure #5386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
882e8cb
fix(cli): respect server telemetry settings correctly
shirshanka Jul 13, 2022
7763f32
Skipping bigquery tables where we can't convert partition id to datet…
treff7es Jul 13, 2022
00dae79
Merge branch 'master' into graceful_bq_partition_id_failure
treff7es Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions metadata-ingestion/src/datahub/ingestion/source/sql/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,17 +868,29 @@ def generate_partition_profiler_query(
partitioned table.
See more about partitioned tables at https://cloud.google.com/bigquery/docs/partitioned-tables
"""

logger.debug(
f"generate partition profiler query for schema: {schema} and table {table}, partition_datetime: {partition_datetime}"
)
partition = self.get_latest_partition(schema, table)
if partition:
partition_where_clause: str
logger.debug(f"{table} is partitioned and partition column is {partition}")
(
partition_datetime,
upper_bound_partition_datetime,
) = get_partition_range_from_partition_id(
partition.partition_id, partition_datetime
)
try:
(
partition_datetime,
upper_bound_partition_datetime,
) = get_partition_range_from_partition_id(
partition.partition_id, partition_datetime
)
except ValueError as e:
logger.error(
f"Unable to get partition range for partition id: {partition.partition_id} it failed with exception {e}"
)
self.report.invalid_partition_ids[
f"{schema}.{table}"
] = partition.partition_id
return None, None

if partition.data_type in ("TIMESTAMP", "DATETIME"):
partition_where_clause = "{column_name} BETWEEN '{partition_id}' AND '{upper_bound_partition_id}'".format(
column_name=partition.column_name,
Expand Down
3 changes: 2 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,8 @@ def loop_profiler_requests(
database=None, schema=schema, table=table
):
self.report.report_warning(
"profile skipped as partitioned table empty", dataset_name
"profile skipped as partitioned table is empty or partition id was invalid",
dataset_name,
)
continue

Expand Down
1 change: 1 addition & 0 deletions metadata-ingestion/src/datahub/ingestion/source_report/sql/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ class BigQueryReport(SQLSourceReport):
table_metadata: Dict[str, List[str]] = field(default_factory=dict)
profile_table_selection_criteria: Dict[str, str] = field(default_factory=dict)
selected_profile_tables: Dict[str, List[str]] = field(default_factory=dict)
invalid_partition_ids: Dict[str, str] = field(default_factory=dict)