Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(siblings): fixing lineage fetching for siblings & sources #5415

Merged
merged 2 commits into from
Jul 19, 2022
Merged

fix(siblings): fixing lineage fetching for siblings & sources #5415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2799f3d
fixing lineage fetching for siblings & sources
gabe-lyons Jul 15, 2022
0663406
ignoring warning
gabe-lyons Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions datahub-web-react/src/graphql/lineage.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ fragment lineageNodeProperties on EntityWithRelationships {
}
}

fragment relationshipFields on EntityWithRelationships {
fragment lineageFields on EntityWithRelationships {
...lineageNodeProperties
... on Dataset {
siblings {
Expand All @@ -224,10 +224,10 @@ fragment relationshipFields on EntityWithRelationships {
}
}
}
upstream: lineage(input: { direction: UPSTREAM, start: 0, count: 100 }) {
upstream: lineage(input: { direction: UPSTREAM, start: 0, count: 100, separateSiblings: $separateSiblings }) {
...leafLineageResults
}
downstream: lineage(input: { direction: DOWNSTREAM, start: 0, count: 100 }) {
downstream: lineage(input: { direction: DOWNSTREAM, start: 0, count: 100, separateSiblings: $separateSiblings }) {
...leafLineageResults
}
}
Expand All @@ -239,7 +239,7 @@ fragment fullLineageResults on EntityLineageResult {
relationships {
type
entity {
...relationshipFields
...lineageFields
}
}
}
Expand Down
20 changes: 20 additions & 0 deletions datahub-web-react/src/graphql/relationships.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,23 @@ fragment leafRelationshipResults on EntityRelationshipsResult {
}
}
}

fragment relationshipFields on EntityWithRelationships {
...lineageNodeProperties
... on Dataset {
siblings {
isPrimary
siblings {
urn
type
...lineageNodeProperties
}
}
}
upstream: lineage(input: { direction: UPSTREAM, start: 0, count: 100 }) {
...leafLineageResults
}
downstream: lineage(input: { direction: DOWNSTREAM, start: 0, count: 100 }) {
...leafLineageResults
}
}
9 changes: 9 additions & 0 deletions smoke-test/tests/cypress/cypress/integration/siblings/siblings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@ describe('siblings', () => {

it('can view individual nodes', () => {
cy.login();

const resizeObserverLoopErrRe = /^[^(ResizeObserver loop limit exceeded)]/
cy.on('uncaught:exception', (err) => {
/* returning false here prevents Cypress from failing the test */
if (resizeObserverLoopErrRe.test(err.message)) {
return false
}
})
Comment on lines +35 to +41
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error is virtual browser specific and is safe to skip: https://stackoverflow.com/questions/49384120/resizeobserver-loop-limit-exceeded


cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:dbt,cypress_project.jaffle_shop.customers,PROD)/?is_lineage_mode=false');

// navigate to the bq entity
Expand Down