Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): intermittent failure in github actions #5452

Merged
merged 28 commits into from
Jul 26, 2022
Merged

fix(build): intermittent failure in github actions #5452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4c6e263
fix(build): verbose logging for ingestion image
anshbansal Jul 20, 2022
6de4973
force TLS
anshbansal Jul 20, 2022
510eddc
add check for quickstart on windows
anshbansal Jul 20, 2022
9375726
fix workflow
anshbansal Jul 20, 2022
608f038
fix workflow
anshbansal Jul 20, 2022
ab9f8ee
cancel running jobs on new pushes
anshbansal Jul 20, 2022
9520359
check platform details
anshbansal Jul 20, 2022
2bcf5d7
try with windows 2019
anshbansal Jul 20, 2022
a553dfd
add more debug information
anshbansal Jul 21, 2022
250e9be
remove windows quickstart check
anshbansal Jul 21, 2022
488b35e
add debugging information for smoke tests
anshbansal Jul 21, 2022
8f6850b
Merge remote-tracking branch 'origin' into intermittent-failure-debug
anshbansal Jul 22, 2022
a34dbda
change to the redirected URL
anshbansal Jul 22, 2022
bf16c50
add pip freeze to show list of dependencies installed
anshbansal Jul 22, 2022
b5763eb
dummy change to run metadata ingestion
anshbansal Jul 22, 2022
9051670
fix pip freeze for venv
anshbansal Jul 22, 2022
9d568c9
use base jdk8 image
anshbansal Jul 22, 2022
9aab4e7
re-run on changes in gradle
anshbansal Jul 22, 2022
f288b40
reverting changes
anshbansal Jul 22, 2022
ac95862
merge master
anshbansal Jul 22, 2022
aa44740
use redirected url
anshbansal Jul 22, 2022
33e5f1e
merge master
anshbansal Jul 22, 2022
8269e73
add env variables to change image used for datahub components
anshbansal Jul 25, 2022
c7ebba7
don't run docker ingestion build every time
anshbansal Jul 25, 2022
1e26bb8
fix path/paths-ignore for workflows
anshbansal Jul 25, 2022
da6afcd
revert redirect url
anshbansal Jul 25, 2022
283f1c3
update datahub-ingestion to build on push always
shirshanka Jul 26, 2022
5179464
only store logs on failure
anshbansal Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ on:
branches:
- master
paths-ignore:
- "docker/**"
- "docs/**"
- "**.md"
release:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/check-datahub-jars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- master
paths-ignore:
- "docker/**"
- "docs/**"
- "**.md"
pull_request:
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/docker-feast-source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,22 @@ on:
push:
branches:
- master
paths-ignore:
- 'docs/**'
- '**.md'
paths:
- 'metadata-ingestion/src/datahub/ingestion/source/feast_image/**'
- '.github/workflows/docker-feast-source.yml'
pull_request:
branches:
- master
paths:
- 'metadata-ingestion/src/datahub/ingestion/source/feast_image/**'
- '.github/workflows/docker-feast-source.yml'
paths_ignore:
- '**.md'
- '**.env'
release:
types: [published, edited]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
setup:
runs-on: ubuntu-latest
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/docker-ingestion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,17 @@ on:
branches:
- master
paths:
- "docker/**"
- "metadata-ingestion/**"
- "metadata-models/**"
- "docker/datahub-ingestion/**"
- ".github/workflows/docker-ingestion.yml"
paths_ignore:
- "**.md"
- "**.env"
release:
types: [published, edited]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
setup:
runs-on: ubuntu-latest
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/docker-postgres-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ on:
push:
branches:
- master
paths-ignore:
- 'docs/**'
- '**.md'
paths:
- './docker/postgres-setup/**'
- '.github/workflows/docker-postgres-setup.yml'
pull_request:
branches:
- master
Expand All @@ -15,6 +15,10 @@ on:
release:
types: [published, edited]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
setup:
runs-on: ubuntu-latest
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/docker-unified.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,23 @@ jobs:
run: |
echo "$DATAHUB_VERSION"
./smoke-test/smoke.sh
- name: store logs
if: failure()
run: |
docker ps -a
docker logs datahub-gms >& gms.log
- name: Upload logs
uses: actions/upload-artifact@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have previously run out of artifact storage, this will accelerate it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't aware of limit on artifact storage. Changed to be only on failure

if: failure()
with:
name: docker logs
path: "*.log"
- name: Upload screenshots
uses: actions/upload-artifact@v2
if: failure()
with:
name: cypress-snapshots
path: smoke-test/tests/cypress/cypress/screenshots/
- uses: actions/upload-artifact@v2
if: always()
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/metadata-ingestion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ jobs:
run: ./metadata-ingestion/scripts/install_deps.sh
- name: Run metadata-ingestion tests
run: ./gradlew :metadata-ingestion:build :metadata-ingestion:${{ matrix.command }} -x:metadata-ingestion:testQuick -x:metadata-ingestion:check
- name: pip freeze show list installed
if: always()
run: source metadata-ingestion/venv/bin/activate && pip freeze
- uses: actions/upload-artifact@v2
if: always()
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/metadata-io.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ on:
release:
types: [published]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
build:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/metadata-model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
release:
types: [published, edited]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
setup:
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publish-datahub-jars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ on:
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:


concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:

check-secret:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/spark-smoke-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ on:
release:
types: [published, edited]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
spark-smoke-test:
runs-on: ubuntu-latest
Expand Down
8 changes: 4 additions & 4 deletions docker/docker-compose-with-cassandra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ services:
kafka-setup:
build:
context: kafka-setup
image: linkedin/datahub-kafka-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_KAFKA_SETUP_IMAGE:-linkedin/datahub-kafka-setup}:${DATAHUB_VERSION:-head}
env_file: kafka-setup/env/docker.env
hostname: kafka-setup
container_name: kafka-setup
Expand Down Expand Up @@ -85,7 +85,7 @@ services:
build:
context: ../
dockerfile: docker/elasticsearch-setup/Dockerfile
image: linkedin/datahub-elasticsearch-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_ELASTIC_SETUP_IMAGE:-linkedin/datahub-elasticsearch-setup}:${DATAHUB_VERSION:-head}
env_file: elasticsearch-setup/env/docker.env
hostname: elasticsearch-setup
container_name: elasticsearch-setup
Expand Down Expand Up @@ -120,7 +120,7 @@ services:
build:
context: ../
dockerfile: docker/datahub-gms/Dockerfile
image: linkedin/datahub-gms:${DATAHUB_VERSION:-head}
image: ${DATAHUB_GMS_IMAGE:-linkedin/datahub-gms}:${DATAHUB_VERSION:-head}
env_file: ./datahub-gms/env/docker.cassandra.env
hostname: datahub-gms
container_name: datahub-gms
Expand All @@ -136,7 +136,7 @@ services:
build:
context: ../
dockerfile: docker/datahub-frontend/Dockerfile
image: linkedin/datahub-frontend-react:${DATAHUB_VERSION:-head}
image: ${DATAHUB_FRONTEND_IMAGE:-linkedin/datahub-frontend-react}:${DATAHUB_VERSION:-head}
env_file: datahub-frontend/env/docker.env
hostname: datahub-frontend-react
container_name: datahub-frontend-react
Expand Down
8 changes: 4 additions & 4 deletions docker/docker-compose-without-neo4j.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ services:
kafka-setup:
build:
context: kafka-setup
image: linkedin/datahub-kafka-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_KAFKA_SETUP_IMAGE:-linkedin/datahub-kafka-setup}:${DATAHUB_VERSION:-head}
env_file: kafka-setup/env/docker.env
hostname: kafka-setup
container_name: kafka-setup
Expand Down Expand Up @@ -72,7 +72,7 @@ services:
build:
context: ../
dockerfile: docker/elasticsearch-setup/Dockerfile
image: linkedin/datahub-elasticsearch-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_ELASTIC_SETUP_IMAGE:-linkedin/datahub-elasticsearch-setup}:${DATAHUB_VERSION:-head}
env_file: elasticsearch-setup/env/docker.env
hostname: elasticsearch-setup
container_name: elasticsearch-setup
Expand All @@ -83,7 +83,7 @@ services:
build:
context: ../
dockerfile: docker/datahub-gms/Dockerfile
image: linkedin/datahub-gms:${DATAHUB_VERSION:-head}
image: ${DATAHUB_GMS_IMAGE:-linkedin/datahub-gms}:${DATAHUB_VERSION:-head}
env_file: datahub-gms/env/docker-without-neo4j.env
hostname: datahub-gms
container_name: datahub-gms
Expand All @@ -98,7 +98,7 @@ services:
build:
context: ../
dockerfile: docker/datahub-frontend/Dockerfile
image: linkedin/datahub-frontend-react:${DATAHUB_VERSION:-head}
image: ${DATAHUB_FRONTEND_IMAGE:-linkedin/datahub-frontend-react}:${DATAHUB_VERSION:-head}
env_file: datahub-frontend/env/docker.env
hostname: datahub-frontend-react
container_name: datahub-frontend-react
Expand Down
8 changes: 4 additions & 4 deletions docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ services:
kafka-setup:
build:
context: kafka-setup
image: linkedin/datahub-kafka-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_KAFKA_SETUP_IMAGE:-linkedin/datahub-kafka-setup}:${DATAHUB_VERSION:-head}
env_file: kafka-setup/env/docker.env
hostname: kafka-setup
container_name: kafka-setup
Expand Down Expand Up @@ -84,7 +84,7 @@ services:
build:
context: ../
dockerfile: docker/elasticsearch-setup/Dockerfile
image: linkedin/datahub-elasticsearch-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_ELASTIC_SETUP_IMAGE:-linkedin/datahub-elasticsearch-setup}:${DATAHUB_VERSION:-head}
env_file: elasticsearch-setup/env/docker.env
hostname: elasticsearch-setup
container_name: elasticsearch-setup
Expand All @@ -95,7 +95,7 @@ services:
build:
context: ../
dockerfile: docker/datahub-gms/Dockerfile
image: linkedin/datahub-gms:${DATAHUB_VERSION:-head}
image: ${DATAHUB_GMS_IMAGE:-linkedin/datahub-gms}:${DATAHUB_VERSION:-head}
hostname: datahub-gms
container_name: datahub-gms
ports:
Expand All @@ -110,7 +110,7 @@ services:
build:
context: ../
dockerfile: docker/datahub-frontend/Dockerfile
image: linkedin/datahub-frontend-react:${DATAHUB_VERSION:-head}
image: ${DATAHUB_FRONTEND_IMAGE:-linkedin/datahub-frontend-react}:${DATAHUB_VERSION:-head}
env_file: datahub-frontend/env/docker.env
hostname: datahub-frontend-react
container_name: datahub-frontend-react
Expand Down
8 changes: 4 additions & 4 deletions docker/quickstart/docker-compose-without-neo4j-m1.quickstart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ services:
- ELASTIC_CLIENT_HOST=elasticsearch
- ELASTIC_CLIENT_PORT=9200
hostname: datahub-frontend-react
image: linkedin/datahub-frontend-react:${DATAHUB_VERSION:-head}
image: ${DATAHUB_FRONTEND_IMAGE:-linkedin/datahub-frontend-react}:${DATAHUB_VERSION:-head}
ports:
- ${DATAHUB_MAPPED_FRONTEND_PORT:-9002}:9002
volumes:
Expand Down Expand Up @@ -81,7 +81,7 @@ services:
- DATAHUB_TELEMETRY_ENABLED=${DATAHUB_TELEMETRY_ENABLED:-true}
- PE_CONSUMER_ENABLED=true
hostname: datahub-gms
image: linkedin/datahub-gms:${DATAHUB_VERSION:-head}
image: ${DATAHUB_GMS_IMAGE:-linkedin/datahub-gms}:${DATAHUB_VERSION:-head}
ports:
- ${DATAHUB_MAPPED_GMS_PORT:-8080}:8080
volumes:
Expand Down Expand Up @@ -115,7 +115,7 @@ services:
- ELASTICSEARCH_PORT=9200
- ELASTICSEARCH_PROTOCOL=http
hostname: elasticsearch-setup
image: linkedin/datahub-elasticsearch-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_ELASTIC_SETUP_IMAGE:-linkedin/datahub-elasticsearch-setup}:${DATAHUB_VERSION:-head}
kafka-setup:
container_name: kafka-setup
depends_on:
Expand All @@ -125,7 +125,7 @@ services:
- KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
- KAFKA_BOOTSTRAP_SERVER=broker:29092
hostname: kafka-setup
image: linkedin/datahub-kafka-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_KAFKA_SETUP_IMAGE:-linkedin/datahub-kafka-setup}:${DATAHUB_VERSION:-head}
mysql:
command: --character-set-server=utf8mb4 --collation-server=utf8mb4_bin
container_name: mysql
Expand Down
8 changes: 4 additions & 4 deletions docker/quickstart/docker-compose-without-neo4j.quickstart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ services:
- ELASTIC_CLIENT_HOST=elasticsearch
- ELASTIC_CLIENT_PORT=9200
hostname: datahub-frontend-react
image: linkedin/datahub-frontend-react:${DATAHUB_VERSION:-head}
image: ${DATAHUB_FRONTEND_IMAGE:-linkedin/datahub-frontend-react}:${DATAHUB_VERSION:-head}
ports:
- 9002:9002
volumes:
Expand Down Expand Up @@ -84,7 +84,7 @@ services:
- UI_INGESTION_ENABLED=true
- UI_INGESTION_DEFAULT_CLI_VERSION=0.8.41
hostname: datahub-gms
image: linkedin/datahub-gms:${DATAHUB_VERSION:-head}
image: ${DATAHUB_GMS_IMAGE:-linkedin/datahub-gms}:${DATAHUB_VERSION:-head}
ports:
- 8080:8080
volumes:
Expand Down Expand Up @@ -118,7 +118,7 @@ services:
- ELASTICSEARCH_PORT=9200
- ELASTICSEARCH_PROTOCOL=http
hostname: elasticsearch-setup
image: linkedin/datahub-elasticsearch-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_ELASTIC_SETUP_IMAGE:-linkedin/datahub-elasticsearch-setup}:${DATAHUB_VERSION:-head}
kafka-setup:
container_name: kafka-setup
depends_on:
Expand All @@ -128,7 +128,7 @@ services:
- KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
- KAFKA_BOOTSTRAP_SERVER=broker:29092
hostname: kafka-setup
image: linkedin/datahub-kafka-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_KAFKA_SETUP_IMAGE:-linkedin/datahub-kafka-setup}:${DATAHUB_VERSION:-head}
mysql:
command: --character-set-server=utf8mb4 --collation-server=utf8mb4_bin
container_name: mysql
Expand Down
8 changes: 4 additions & 4 deletions docker/quickstart/docker-compose.quickstart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ services:
- ELASTIC_CLIENT_HOST=elasticsearch
- ELASTIC_CLIENT_PORT=9200
hostname: datahub-frontend-react
image: linkedin/datahub-frontend-react:${DATAHUB_VERSION:-head}
image: ${DATAHUB_FRONTEND_IMAGE:-linkedin/datahub-frontend-react}:${DATAHUB_VERSION:-head}
ports:
- ${DATAHUB_MAPPED_FRONTEND_PORT:-9002}:9002
volumes:
Expand Down Expand Up @@ -89,7 +89,7 @@ services:
- UI_INGESTION_ENABLED=true
- UI_INGESTION_DEFAULT_CLI_VERSION=0.8.41
hostname: datahub-gms
image: linkedin/datahub-gms:${DATAHUB_VERSION:-head}
image: ${DATAHUB_GMS_IMAGE:-linkedin/datahub-gms}:${DATAHUB_VERSION:-head}
ports:
- ${DATAHUB_MAPPED_GMS_PORT:-8080}:8080
volumes:
Expand Down Expand Up @@ -123,7 +123,7 @@ services:
- ELASTICSEARCH_PORT=9200
- ELASTICSEARCH_PROTOCOL=http
hostname: elasticsearch-setup
image: linkedin/datahub-elasticsearch-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_ELASTIC_SETUP_IMAGE:-linkedin/datahub-elasticsearch-setup}:${DATAHUB_VERSION:-head}
kafka-setup:
container_name: kafka-setup
depends_on:
Expand All @@ -133,7 +133,7 @@ services:
- KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
- KAFKA_BOOTSTRAP_SERVER=broker:29092
hostname: kafka-setup
image: linkedin/datahub-kafka-setup:${DATAHUB_VERSION:-head}
image: ${DATAHUB_KAFKA_SETUP_IMAGE:-linkedin/datahub-kafka-setup}:${DATAHUB_VERSION:-head}
mysql:
command: --character-set-server=utf8mb4 --collation-server=utf8mb4_bin
container_name: mysql
Expand Down