Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest): bigquery-lineage - allow tables and datasets in uppercase #6739

Merged
merged 8 commits into from
Dec 14, 2022
Merged

refactor(ingest): bigquery-lineage - allow tables and datasets in uppercase #6739

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f4c0af3
fix(ingest): sql lineage parser impl - makes it possible to return th…
PatrickfBraz Dec 12, 2022
b3d423b
refactor(ingest): bigquery-lineage - creates a parameter to allow tab…
PatrickfBraz Dec 13, 2022
cc020f8
chore(ingest): bigquery-lineage - applies changes to adjust the lint
PatrickfBraz Dec 13, 2022
e2db217
chore(ingest): bigquery-lineage - changes to adjust the lint
PatrickfBraz Dec 13, 2022
40bb4ab
Merge branch 'master' into bigquery-lineage-issues
PatrickfBraz Dec 13, 2022
c89a9c7
test(ingest): bigquery-sql-lineage - adds tests for uppercase table n…
PatrickfBraz Dec 13, 2022
d597774
Merge branch 'bigquery-lineage-issues' of github.com:PatrickfBraz/dat…
PatrickfBraz Dec 13, 2022
9cee5b4
Merge branch 'master' into bigquery-lineage-issues
hsheth2 Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/utilities/sql_lineage_parser_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def get_tables(self) -> List[str]:
logger.error("sql holder not present so cannot get tables")
return result
for table in self._sql_holder.source_tables:
table_normalized = re.sub(r"^<default>.", "", str(table))
table_normalized = re.sub(r"^<default>.", "", table.raw_name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a configurable behavior and disabled by default and, please, can you add some test cases as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!! I will do that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treff7es Can you have a look?

result.append(str(table_normalized))

# We need to revert TOKEN replacements
Expand Down